Handle CondFunc exception when resolving attributes#14560
Merged
AUTOMATIC1111 merged 1 commit intoAUTOMATIC1111:devfrom Jan 7, 2024
Merged
Handle CondFunc exception when resolving attributes#14560AUTOMATIC1111 merged 1 commit intoAUTOMATIC1111:devfrom
AUTOMATIC1111 merged 1 commit intoAUTOMATIC1111:devfrom
Conversation
AUTOMATIC1111
approved these changes
Jan 7, 2024
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AttributeErrorongetattr. This happens whenorig_funcstring refers to a non-existent object.For example, I attempted to hijack sd-webui-controlnet
annotator.anime_face_segment.AnimeFaceSegment.__init__in my extension. However,annotator.anime_face_segmentis only available starting from ControlNet >= 1.1.420.Screenshots/videos:
Before this change, an uncaught exception may be thrown at
CondFuncinstantiation, andfoo()will not be executed unless we wrap everyCondFuncwith atry-exceptblock, which is inconvenient.File "D:\stable-diffusion-webui\modules\sd_hijack_utils.py", line 15, in __new__ resolved_obj = getattr(resolved_obj, attr_name) AttributeError: module 'annotator' has no attribute 'anime_face_segment'After this change, a warning will be printed indicating this
CondFuncdidn't take effect:Checklist: