Error handling for unsupported transparency#14958
Merged
AUTOMATIC1111 merged 1 commit intoAUTOMATIC1111:devfrom Mar 4, 2024
Merged
Error handling for unsupported transparency#14958AUTOMATIC1111 merged 1 commit intoAUTOMATIC1111:devfrom
AUTOMATIC1111 merged 1 commit intoAUTOMATIC1111:devfrom
Conversation
When input images (palette mode) have transparency (bytes) in info, the output images (RGB mode) will inherit it, causing ValueError in Pillow:PIL/PngImagePlugin.py#1364 when trying to unpack this bytes. This commit check the PNG mode and transparency info, removing transparency if it's RGB mode and transparency is bytes
Owner
|
I get But no error. Using Pillow 9.5.0 as specified in the requirements file. |
Contributor
Author
Strange. I'm sure I am using Pillow 9.5.0, I will check the reason, thanks for review. |
AUTOMATIC1111
approved these changes
Mar 4, 2024
Owner
|
Managed to reproduce it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When input images (palette mode) have transparency (bytes) in info, the output images (RGB mode) will inherit it, causing ValueError in Pillow:PIL/PngImagePlugin.py#1364 when trying to unpack this bytes.
This commit check the PNG mode and transparency info, removing transparency if it's RGB mode and transparency is bytes
Reproduce
Test file

Screenshots/videos:
Before

After

Checklist: