Skip to content

handle 0 wheel deltaY#15268

Merged
AUTOMATIC1111 merged 1 commit intoAUTOMATIC1111:devfrom
light-and-ray:handle_0_wheel_deltaX
Mar 16, 2024
Merged

handle 0 wheel deltaY#15268
AUTOMATIC1111 merged 1 commit intoAUTOMATIC1111:devfrom
light-and-ray:handle_0_wheel_deltaX

Conversation

@light-and-ray
Copy link
Contributor

@light-and-ray light-and-ray commented Mar 15, 2024

Description

I had a strange bug. When I was scrolling on remote PC via VNC remote desktop, I wasn't able to zoom out. I've found it's because deltaX was always 0. If I do it with real mouse - everything is OK

It's not really necessary to fix it in this way, this bug is rare and it's a problem of VNC. But I think nothing will be wrong with this change

Checklist:

@light-and-ray light-and-ray changed the title handle 0 wheel deltaX handle 0 wheel deltaY Mar 15, 2024
@AUTOMATIC1111
Copy link
Owner

Any comment from @daswer123? Also could this be written in one line, something like (e.deltaY || -e.wheelDelta)?

@light-and-ray light-and-ray force-pushed the handle_0_wheel_deltaX branch from c0312d6 to 5f30288 Compare March 16, 2024 13:55
@light-and-ray
Copy link
Contributor Author

pushed

@light-and-ray light-and-ray force-pushed the handle_0_wheel_deltaX branch from 5f30288 to c364b60 Compare March 16, 2024 14:08
@AUTOMATIC1111 AUTOMATIC1111 merged commit 874809e into AUTOMATIC1111:dev Mar 16, 2024
@light-and-ray light-and-ray deleted the handle_0_wheel_deltaX branch March 17, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants