Fix: Remove script callbacks in ordered_callbacks_map#15428
Merged
AUTOMATIC1111 merged 1 commit intoAUTOMATIC1111:devfrom Apr 1, 2024
Merged
Fix: Remove script callbacks in ordered_callbacks_map#15428AUTOMATIC1111 merged 1 commit intoAUTOMATIC1111:devfrom
AUTOMATIC1111 merged 1 commit intoAUTOMATIC1111:devfrom
Conversation
AUTOMATIC1111
approved these changes
Apr 1, 2024
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes script callbacks persisting after
script_callbacks.remove_current_script_callbacks()is called. This would cause unexpected behavior by having extension callbacks not update in subsequent runs.The problem was that
remove_callbacks()did not remove callbacks from ordered_callbacks_map dict. We iterate through ordered_callbacks_map like callbacks_map to remove the script's callbacks.The bug was introduced in commit 7e5e673.
Screenshots/videos:
Checklist: