Conversation
fix broken Replace preview for extra networks tabs edit metadata caused by #11808
6 tasks
AUTOMATIC1111
approved these changes
Jul 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix bug [Bug]: Replace preview button always saves gird image #16115
the cause is Always show extra networks tabs in the UI #11808 when the
extra networksare moved to tabs.offsetParentproperty isnullin
all_gallery_buttons()we use the when not displayed offsetParent isnullbehavior to select only the gallery that is currently being displayedstable-diffusion-webui/javascript/ui.js
Line 14 in a30b19d
but this no longer works after #11808 as the tab gallery will always be
not displayedwhen we switched to the extra networks tab to replace the previewfix solution
Implement a different galleries selector base on element ID to directly to select the specific gallery
I create a new function because I don't want to touch the existing
selected_gallery_index()in case it breaks something elseChecklist: