Skip to content

Add handling for large IDs beyond Integer.MAX_VALUE#371

Merged
Zhannyhong merged 2 commits into
AY2425S2-CS2103T-T17-3:masterfrom
themintchoco:handle-large-id
Apr 7, 2025
Merged

Add handling for large IDs beyond Integer.MAX_VALUE#371
Zhannyhong merged 2 commits into
AY2425S2-CS2103T-T17-3:masterfrom
themintchoco:handle-large-id

Conversation

@themintchoco
Copy link
Copy Markdown
Collaborator

Closes #306

@themintchoco themintchoco added this to the v1.6 milestone Apr 7, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/test/java/tutorly/logic/parser/ParserUtilTest.java:81

  • Since the behavior for large IDs now returns UNKNOWN_ID, consider adding a test case that explicitly verifies ParserUtil.parseSessionId returns Session.UNKNOWN_ID for inputs exceeding Integer.MAX_VALUE.
assertThrows(ParseException.class, Session.MESSAGE_INVALID_ID, () -> ParserUtil.parseSessionId(Long.toString(Integer.MAX_VALUE + 1)));

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ Complexity Δ
src/main/java/tutorly/commons/util/StringUtil.java 95.23% <100.00%> (+0.50%) 9.00 <1.00> (+1.00)
src/main/java/tutorly/logic/parser/ParserUtil.java 97.14% <100.00%> (+0.11%) 33.00 <0.00> (+2.00)
src/main/java/tutorly/model/person/Identity.java 85.71% <ø> (ø) 13.00 <0.00> (ø)
src/main/java/tutorly/model/session/Session.java 67.64% <ø> (ø) 16.00 <0.00> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@Zhannyhong Zhannyhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zhannyhong Zhannyhong merged commit 02b9859 into AY2425S2-CS2103T-T17-3:master Apr 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[PE-D][Tester D] Different Error Messages for same type of error

3 participants