Implement validate_tables: sorted table verification and Ptr table checks#62
Merged
AaronRobinsonMSFT merged 8 commits intomasterfrom Feb 15, 2026
Merged
Conversation
…e check - Add mdc_uncompressed_table_heap flag to track #- vs #~ table heap - Set the flag in md_create_handle when tables_heap_uncompressed is true - Validate that *Ptr tables are not present in compressed (#~) table heaps - Validate that tables marked as sorted are actually sorted by their keys Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>
Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>
Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>
Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement TODOs in validate_tables method
Implement validate_tables: sorted table verification and Ptr table checks
Feb 14, 2026
…t APIs Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>
Collaborator
|
@copilot update the logic in md_write_to_buffer to use the |
Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>
Contributor
Author
Done in 6f95ee2 — |
Collaborator
jkoritzinsky
left a comment
There was a problem hiding this comment.
@copilot Please implement this feedback
…pdate Ptr comment Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>
Contributor
Author
jkoritzinsky
approved these changes
Feb 15, 2026
AaronRobinsonMSFT
approved these changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mdc_uncompressed_table_heapflag tomdcxt_flag_tininternal.hmd_create_handleinentry.cwhentables_heap_uncompressedis truecreate_and_fill_indirect_tableineditor.cwhen Ptr tables are introduced via edit APIsmdc_uncompressed_table_heapflag inmd_write_to_bufferfor#-stream name selection instead ofmdc_minimal_deltavalidate_tablesinstreams.c:get_table_keys)mdcxt_flag_tenumOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.