Suppress MSVC C4200 warning in dnmd_pdb.h#67
Merged
AaronRobinsonMSFT merged 1 commit intomasterfrom Mar 1, 2026
Merged
Conversation
The header uses flexible array members (zero-sized arrays) in md_sequence_points_t, md_local_constant_sig_t, and md_imports_t. MSVC warns about this (C4200), which breaks consumers that build with -Werror/WX. Matches the existing pattern in corhdr.h. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures the public dnmd_pdb.h header can be consumed by MSVC projects that treat warnings as errors by suppressing MSVC warning C4200 (triggered by flexible array members used in several structs).
Changes:
- Add MSVC-only
#pragma warning(push)+#pragma warning(disable:4200)near the top ofdnmd_pdb.h - Add the corresponding MSVC-only
#pragma warning(pop)near the end ofdnmd_pdb.h
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header uses flexible array members (zero-sized arrays) in md_sequence_points_t, md_local_constant_sig_t, and md_imports_t. MSVC warns about this (C4200), which breaks consumers that build with -Werror/WX. Matches the existing pattern in corhdr.h.