Move md_get_pdb_id to dnmd_pdb.h and reduce CI matrix#70
Merged
AaronRobinsonMSFT merged 2 commits intomasterfrom Mar 12, 2026
Merged
Move md_get_pdb_id to dnmd_pdb.h and reduce CI matrix#70AaronRobinsonMSFT merged 2 commits intomasterfrom
AaronRobinsonMSFT merged 2 commits intomasterfrom
Conversation
Move the md_get_pdb_id declaration from dnmd.h to dnmd_pdb.h where it belongs alongside other Portable PDB APIs. Fix the implementation to always write back the required buffer size before checking if the caller's buffer is large enough, enabling callers to query the needed size with a too-small buffer. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace the full 12-leg matrix (3 OS × 2 flavors × 2 vendored) with a sparse 8-leg matrix to reduce CI costs while maintaining coverage: - Ubuntu: Debug and Release, both vendored modes (4 legs) - macOS: Debug vendored, Release non-vendored (2 legs) - Windows: Release vendored, Debug non-vendored (2 legs) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the public Portable PDB API surface by relocating md_get_pdb_id into the Portable PDB header, updates md_get_pdb_id to support “size query” usage by always writing back the required length, and reduces the GitHub Actions build matrix to a smaller set of representative configurations.
Changes:
- Move the
md_get_pdb_iddeclaration fromdnmd.htodnmd_pdb.h. - Update
md_get_pdb_idto write the required*pdb_id_lenbefore rejecting an undersized buffer. - Reduce CI build matrix legs using an explicit
matrix.includelist.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/inc/dnmd_pdb.h |
Adds the md_get_pdb_id declaration alongside other Portable PDB APIs. |
src/inc/dnmd.h |
Removes the md_get_pdb_id declaration from the core public header. |
src/dnmd/entry.c |
Adjusts md_get_pdb_id to support size-query semantics (but currently needs a safety fix). |
.github/workflows/main.yml |
Switches to a sparse CI matrix to reduce total jobs while keeping coverage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Move md_get_pdb_id to dnmd_pdb.h and fix size query pattern
md_get_pdb_iddeclaration fromdnmd.htodnmd_pdb.hwhere it belongs alongside other Portable PDB APIs.Reduce CI matrix to sparse configuration
Replace the full 12-leg matrix (3 OS × 2 flavors × 2 vendored) with a sparse 8-leg matrix to reduce CI costs while maintaining coverage: