Fix shared lib symlink installation path#2326
Merged
cary-ilm merged 3 commits intoAcademySoftwareFoundation:mainfrom Apr 1, 2026
Merged
Fix shared lib symlink installation path#2326cary-ilm merged 3 commits intoAcademySoftwareFoundation:mainfrom
cary-ilm merged 3 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Signed-off-by: Jhacson Meza <jhacsonmeza@gmail.com>
Member
|
This looks fine, thanks. I'd like to extend the CI to catch this error before merging the fix, I'll come up with a suggested change shortly. |
Member
|
#2333 adds a CI test to validate this doesn't break in the future. |
cary-ilm
merged commit 1e4009f
into
AcademySoftwareFoundation:main
50 of 51 checks passed
cary-ilm
added a commit
that referenced
this pull request
Apr 1, 2026
Signed-off-by: Jhacson Meza <jhacsonmeza@gmail.com> Co-authored-by: Cary Phillips <cary@ilm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the installation path of the
libIex.sosymlink whencmake --install . --prefix <custom_path>is used for installation. The solution proposed is the same as AcademySoftwareFoundation/Imath#556, whereCMAKE_INSTALL_FULL_LIBDIRis replaced withCMAKE_INSTALL_LIBDIR.