Skip to content

WIP: Fix cross compilation#384

Closed
Ericson2314 wants to merge 2 commits intoAcademySoftwareFoundation:masterfrom
Ericson2314:fix-cross
Closed

WIP: Fix cross compilation#384
Ericson2314 wants to merge 2 commits intoAcademySoftwareFoundation:masterfrom
Ericson2314:fix-cross

Conversation

@Ericson2314
Copy link
Copy Markdown

The first commit is a cleaned up #221 .

The second commit is WIP and harder because the generators use IO routines from the library that's being built. It's probably just easiest to have them use STL stuff.

Didn't take a look at CMake because it has even worse support for code generators (autoconf can be hacked to do _FOR_BUILD alright, automake however is useless there).

@cary-ilm cary-ilm added the Build A problem with building or installing the library. label Jun 19, 2019
@meshula
Copy link
Copy Markdown
Contributor

meshula commented Aug 10, 2019

Unfortunately, this diff got messed up when we cleaned up the repository history. Would it be possible to close this issue, and re-open it so we can get a clean diff again? Sorry for the nuisance.

@meshula meshula changed the title WIP: Fix cross WIP: Fix cross compilation Oct 4, 2019
@meshula
Copy link
Copy Markdown
Contributor

meshula commented Oct 4, 2019

Is this commit the actual change?

95c49ab

@Ericson2314
Copy link
Copy Markdown
Author

Rebased. The first commit you should be able to apply immediately (I can open a separate PR). The second commit is still the WIP one, though the separate *Internal.h header that was added does help a bit :).

@Ericson2314
Copy link
Copy Markdown
Author

b44ExpLogTable and dwaLookups are the code generators I was mentioning. The less openexpr functionality that is used in those, the easier cross will be because we don't need to build that functionality twice (once for the build platform, once for the host platform).

@meshula
Copy link
Copy Markdown
Contributor

meshula commented Oct 12, 2019

Thanks, I'm traveling now but will review as soon as I can.

@meshula meshula self-assigned this Oct 12, 2019
@Lord-Kamina
Copy link
Copy Markdown
Contributor

If you can eliminate the need for a native build entirely, that'd be cool but I submitted #591 which, among other things, included a stopgap measure for this.

@Ericson2314
Copy link
Copy Markdown
Author

Yeah that's a good idea. This should be modified to use the same stop-gap. Everyone can still benefit from splitting the config file.

@meshula
Copy link
Copy Markdown
Contributor

meshula commented Oct 21, 2019

We've been discussing not generating the elut and tofloat headers on the fly, at all, but that will probably be part of OpenEXR 3. PR #591 is a good stop gap around that issue, and adds logic to deal with MinGW builds as well; I added a few comments over there.

@meshula meshula requested a review from kdt3rd October 21, 2019 05:10
@meshula
Copy link
Copy Markdown
Contributor

meshula commented Oct 21, 2019

I think this looks good, but I'm not an AC person.

@cary-ilm cary-ilm added the Needs Discussion To be discussed in the technical steering committee label Oct 24, 2019
@cary-ilm cary-ilm self-assigned this Oct 31, 2019
@cary-ilm
Copy link
Copy Markdown
Member

Addressed by #606, which removes the auto-generation of the headers entirely. They're regular header files in the repo now.

@cary-ilm cary-ilm closed this Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build A problem with building or installing the library. Needs Discussion To be discussed in the technical steering committee

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants