WIP: Fix cross compilation#384
WIP: Fix cross compilation#384Ericson2314 wants to merge 2 commits intoAcademySoftwareFoundation:masterfrom
Conversation
|
Unfortunately, this diff got messed up when we cleaned up the repository history. Would it be possible to close this issue, and re-open it so we can get a clean diff again? Sorry for the nuisance. |
|
Is this commit the actual change? |
95c49ab to
4673901
Compare
|
Rebased. The first commit you should be able to apply immediately (I can open a separate PR). The second commit is still the WIP one, though the separate |
|
|
|
Thanks, I'm traveling now but will review as soon as I can. |
|
If you can eliminate the need for a native build entirely, that'd be cool but I submitted #591 which, among other things, included a stopgap measure for this. |
|
Yeah that's a good idea. This should be modified to use the same stop-gap. Everyone can still benefit from splitting the config file. |
|
We've been discussing not generating the elut and tofloat headers on the fly, at all, but that will probably be part of OpenEXR 3. PR #591 is a good stop gap around that issue, and adds logic to deal with MinGW builds as well; I added a few comments over there. |
|
I think this looks good, but I'm not an AC person. |
|
Addressed by #606, which removes the auto-generation of the headers entirely. They're regular header files in the repo now. |
The first commit is a cleaned up #221 .
The second commit is WIP and harder because the generators use IO routines from the library that's being built. It's probably just easiest to have them use STL stuff.
Didn't take a look at CMake because it has even worse support for code generators (autoconf can be hacked to do
_FOR_BUILDalright, automake however is useless there).