Skip to content

Add Liquid Staking Precompiles#2083

Merged
ferrell-code merged 11 commits intomasterfrom
fer-homa-precompiles
May 17, 2022
Merged

Add Liquid Staking Precompiles#2083
ferrell-code merged 11 commits intomasterfrom
fer-homa-precompiles

Conversation

@ferrell-code
Copy link
Copy Markdown
Contributor

@ferrell-code ferrell-code commented May 5, 2022

Todo:

@ferrell-code ferrell-code marked this pull request as draft May 5, 2022 03:23
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2022

Codecov Report

Merging #2083 (62080fe) into master (575d668) will increase coverage by 86.49%.
The diff coverage is 74.24%.

❗ Current head 62080fe differs from pull request most recent head 4771fed. Consider uploading reports for the commit 4771fed to get more accurate results

@@             Coverage Diff             @@
##           master    #2083       +/-   ##
===========================================
+ Coverage        0   86.49%   +86.49%     
===========================================
  Files           0       99       +99     
  Lines           0    21157    +21157     
===========================================
+ Hits            0    18300    +18300     
- Misses          0     2857     +2857     
Impacted Files Coverage Δ
modules/support/src/lib.rs 33.33% <ø> (ø)
modules/homa/src/lib.rs 81.48% <74.24%> (ø)
modules/nominees-election/src/tests.rs 100.00% <0.00%> (ø)
modules/honzon-bridge/src/tests.rs 100.00% <0.00%> (ø)
modules/incentives/src/tests.rs 100.00% <0.00%> (ø)
modules/honzon-bridge/src/lib.rs 91.30% <0.00%> (ø)
modules/support/src/dex.rs 28.57% <0.00%> (ø)
modules/evm/src/precompiles/identity.rs 0.00% <0.00%> (ø)
modules/homa-lite/src/tests.rs 100.00% <0.00%> (ø)
modules/asset-registry/src/tests.rs 99.65% <0.00%> (ø)
... and 91 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 575d668...4771fed. Read the comment docs.

@ferrell-code ferrell-code marked this pull request as ready for review May 6, 2022 18:51
Comment thread runtime/common/src/precompile/input.rs Outdated
Comment thread runtime/common/src/precompile/homa.rs
Comment thread runtime/common/src/precompile/homa.rs Outdated
Comment thread runtime/common/src/precompile/homa.rs
zjb0807
zjb0807 previously approved these changes May 10, 2022
Copy link
Copy Markdown
Contributor

@zjb0807 zjb0807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjb0807 zjb0807 requested review from ermalkaleci and xlc May 10, 2022 07:56
Comment thread runtime/common/src/precompile/input.rs Outdated
Comment thread runtime/common/src/precompile/homa.rs
zjb0807
zjb0807 previously approved these changes May 13, 2022
xlc
xlc previously approved these changes May 16, 2022
@ferrell-code ferrell-code dismissed stale reviews from xlc and zjb0807 via 4771fed May 16, 2022 15:59
@ferrell-code ferrell-code merged commit c2c242e into master May 17, 2022
@ferrell-code ferrell-code deleted the fer-homa-precompiles branch May 17, 2022 18:42
@zjb0807 zjb0807 mentioned this pull request May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants