Bugfix for trip scheduling choice #884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-am-sijia
approved these changes
Aug 8, 2024
Contributor
There was a problem hiding this comment.
@jpn-- I commented out another section in simulate.py that also calls the sh_flow.load() that would cause the model to hang. It's in this pr: https://github.com/camsys/activitysim/pull/15
Contributor
Remove problem code for sharrow load
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trip scheduling model currently was set with
allow_zero_probs=Truebut immediately after running the choice model it includes an assertion that all the choices are valid. Really we want to disallow zero probabilities. By setting this to false we also automatically engage underflow protection on the probabilities when the utility dtype is float32 (as happens with sharrow enabled).Also this PR temporarily removes a problematic block of code when tracing and sharrow are both enabled.