Extend type checking to all float datatypes #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MMathisLab
force-pushed
the
celia/fix-790-public
branch
from
0d169cb to
2d5b0b5
Compare
stes
requested changes
Aug 24, 2024
Member
Author
|
docs building git action doesn't pass is fixed in #176 |
Member
|
docs should build again now, main tests not yet. Working on that now. |
Member
|
All right, after #184 this should hopefully finally build! |
Member
|
Ok, raises an actual error: @CeliaBenquet wanna have a shot at fixing this? otherwise I can have a look. |
stes
reviewed
Oct 26, 2024
Member
stes
left a comment
stes
left a comment
There was a problem hiding this comment.
Fix type checking and error message
Member
|
Let's see if this fixes the error |
icarosadero
approved these changes
Oct 26, 2024
Contributor
icarosadero
left a comment
icarosadero
left a comment
There was a problem hiding this comment.
@stes I think this does the trick 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for someone to use discrete labels in a continuous way; this might change the solver to behaviors you might not be expecting so please use with caution.
fix https://github.com/AdaptiveMotorControlLab/CEBRA-dev/pull/791
fix https://github.com/AdaptiveMotorControlLab/CEBRA-dev/issues/790