Inference on layer #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functional prototype for single layer inference Features : - functional basic inference on selected layer - improvements to inference code layout MISSING : - Proper button behaviour - Error if no layer selected - Full test of all functionalities
NOTE : Layer orientation can be hard to determine, anisotropy ends up being wrong due to this depending on whether layer is loaded image or "original" from previous inference
- Fixed button behaviour - Fixed log text errors
Functional prototype for single layer inference Features : - functional basic inference on selected layer - improvements to inference code layout MISSING : - Proper button behaviour - Error if no layer selected - Full test of all functionalities
NOTE : Layer orientation can be hard to determine, anisotropy ends up being wrong due to this depending on whether layer is loaded image or "original" from previous inference
- Fixed button behaviour - Fixed log text errors
- Rebased on rc3 main - Removed debug prints - Added tqdm to reqs - Added more error handling for stats to csv (region.axis_minor_length value errors)
…ControlLab/CellSeg3d into cy/layer-inference
|
Preview page for your plugin is ready here: |
Fixed ref before assignment error
Codecov Report
@@ Coverage Diff @@
## main #26 +/- ##
==========================================
- Coverage 37.80% 36.68% -1.12%
==========================================
Files 37 37
Lines 3383 3538 +155
==========================================
+ Hits 1279 1298 +19
- Misses 2104 2240 +136
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Fixed duplicate code
- Should fix #25 by catching exceptions and quitting thread
vidalmaxime
suggested changes
Aug 12, 2022
Contributor
vidalmaxime
left a comment
vidalmaxime
left a comment
There was a problem hiding this comment.
Nice PR. If you remove the legacy comments in the code and address the small concerns in model_workers, it lgtm.
MMathisLab
approved these changes
Aug 12, 2022
Member
MMathisLab
left a comment
MMathisLab
left a comment
There was a problem hiding this comment.
agree with removing some print statements, looks great!
vidalmaxime
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed PR for #7
Features :
Stop request, waiting for next inference & saving to occur...but then no inf. could occur due to user error #25)ISSUES :
Proper button behaviourTesting all featuresProper error handling/reset when running a job without a folder/layer selected