Skip to content

Commit 55e1cc5

Browse files
fix: Train forces missionName print error (#804)
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
1 parent df306e9 commit 55e1cc5

1 file changed

Lines changed: 16 additions & 4 deletions

File tree

scripts/scr_mission_functions/scr_mission_functions.gml

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -257,6 +257,7 @@ function complete_train_forces_mission(targ_planet, problem_index){
257257
var _mission_string = "";
258258
var _trainer = collect_role_group("all",[name,targ_planet,0], false, man_conditions);
259259
if (array_length(_trainer)){
260+
var _unit_report_string = "";
260261
var _tester = global.character_tester;
261262
var _wis_test_difficulty = -20;
262263
_trainer = _trainer[0];
@@ -284,10 +285,20 @@ function complete_train_forces_mission(targ_planet, problem_index){
284285
var _new_pdf = planet.recruit_pdf((_unit_pass[1]/10));//this will approximate podf improvement for the time being
285286
_mission_string += $"Training of the Pdf went well and improved the quality of the pdf as well as providing sizeable big recruitment improvement for the planet {_new_pdf} new pdf were recruited";
286287
if (_siege_master){
287-
_mission_string += "{_trainer.name()}s trained eye as a Siege Master also allowed him to make several improvements to the planets fortifications (fortification +1)";
288-
288+
_mission_string += $"{_trainer.name()}s trained eye as a Siege Master also allowed him to make several improvements to the planets fortifications (fortification +1)";
289289
planet.alter_fortification(1);
290-
}
290+
} else {
291+
if (roll_dice(1, 100) > 75 && _trainer.intelligence > 45){
292+
_mission_string += $"{_trainer.name()} has proven themselves a great strategist when it comes to defensive structures beyond previousy known ";
293+
var _start_stats = variable_clone(_trainer.get_stat_line());
294+
_trainer.add_trait("siege_master");
295+
var end_stat = _trainer.get_stat_line();
296+
var _stat_diff = compare_stats(end_stat,_start_stats);
297+
_unit_report_string += $"{_trainer.name_role()} Has gained the trait {global.trait_list.siege_master.display_name}, {(print_stat_diffs(_stat_diff))}\n";
298+
_mission_string += "The new insights have allowed for minor improvements to planetary fortifications (fortification +1)";
299+
planet.alter_fortification(1);
300+
}
301+
}
291302
} else {
292303
disp_loss = -5;
293304
_mission_string += "The orgional training mission was a failiure"
@@ -314,7 +325,8 @@ function complete_train_forces_mission(targ_planet, problem_index){
314325
}
315326
planet.add_disposition(disp_loss);
316327
}
317-
scr_popup($"Training Forces on {planet_numeral_name(i)}",_mission_string,"","");
328+
_mission_string += $"\n{_unit_report_string}";
329+
scr_popup($"Training Forces on {planet.name()}",_mission_string,"","");
318330
remove_planet_problem(targ_planet, "train_forces");
319331
_trainer.job = "none";
320332
}

0 commit comments

Comments
 (0)