fix: Train forces missionName print error

[OH296]

Purpose

• Fix a name print error
• also hey let marines earn some traits

Describe your changes/additions

• Self-descriptive.

What can/needs to be improved/changed

• Nothing.

Testing done

• None, and I understand the risks.

Related things and/or additional context

• None.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Summary by CodeRabbit

• New Features
  • Added a rare chance for trainers to gain the "siege_master" trait during training missions, with a detailed report of trait gain and stat changes shown in the mission popup.
  • Mission popup titles now display the actual planet name instead of a numeral.

Walkthrough

By the Omnissiah's will, the function complete_train_forces_mission within the sacred script has been augmented. A new string variable, _unit_report_string, is now initialised upon the discovery of a trainer. Should the training be successful, and the trainer lacks the "siege_master" trait, a rare confluence of fate (random roll and intelligence threshold) may bestow this trait upon the trainer. When this occurs, the script now records and appends a detailed report of the trait gain and any stat changes to the mission popup. The popup title now invokes the true planetary designation, not a numeral.

Changes

Files	Change Summary
scripts/scr_mission_functions/scr_mission_functions.gml	Modified complete_train_forces_mission: Introduced _unit_report_string, rare chance for "siege_master" trait gain, detailed stat change report appended to mission popup, and updated popup title to use planet's actual name.

Possibly related PRs

• fix: planet typo "plant" to "planet" #744: Addresses a typo in complete_train_forces_mission; related by function but not by logic.
• feat: Train forces governor mission #733: Previously implemented the "train_forces" mission completion logic; this PR extends that logic with new trait gain and reporting features.

Suggested labels

Type: Fix, Size: Tiny

Suggested reviewers

• EttyKitty

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 646c0cb and 069b33f.

📒 Files selected for processing (1)

• scripts/scr_mission_functions/scr_mission_functions.gml (3 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

`**/*.gml`: - Macro constants require a space between the constant name and value. Without it, the compiler will throw an error. I.e. `#macro ARR_body_parts["arm"]` will crash the ...

**/*.gml: - Macro constants require a space between the constant name and value. Without it, the compiler will throw an error. I.e. #macro ARR_body_parts["arm"] will crash the game, because there is no space between the array and the name of the macro.

• Color codes in the code shouldn't have any spaces in their id. I.e., color code # 80bf40 will crash the game.
• All code should comply with the main GML documentation: https://manual.gamemaker.io/beta/en/GameMaker_Language/GML_Reference/GML_Reference.htm

• scripts/scr_mission_functions/scr_mission_functions.gml

`**/*.*`: - Having humanly understandable and maintainable code is always the top most priority. - DRY (Don't repeat yourself) principle is also very important. - Ensure that the c...

**/*.*: - Having humanly understandable and maintainable code is always the top most priority.

• DRY (Don't repeat yourself) principle is also very important.
• Ensure that the code is compliant with the CODE_STYLE.MD: https://github.com/Adeptus-Dominus/ChapterMaster/blob/main/docs/CODE_STYLE.md

• scripts/scr_mission_functions/scr_mission_functions.gml

🔇 Additional comments (7)

scripts/scr_mission_functions/scr_mission_functions.gml (7)

260-260: Blessing of the Omnissiah acknowledged: new report mechanism initialized.

This data buffer shall hold sacred records of trait gains and statistical alterations. Logical implementation.

---

293-296: Logical implementation for stat tracking mechanism.

The variable cloning and comparison rituals are properly configured to document the statistical alterations bestowed by the Omnissiah through the siege_master trait.

---

297-298: Sacred trait acquisition report formats properly.

The formatting of the trait acquisition report follows the proper syntax for string concatenation and will display correctly in the mission terminal.

---

327-327: Unit report concatenation: logical implementation.

The sacred texts of unit modifications are properly appended to the mission report string.

---

328-328: Corrected invocation of planetary designation in mission report title.

The modification addresses the original error by using the planet's true designation rather than its numeral identification, which aligns with the PR objective.

---

292-292: ⚠️ Potential issue

Missing sacred prefix '$' detected in string interpolation ritual.

The machine spirits cannot properly interpret the variable reference within the string template. The Omnissiah requires the '$' sigil to be present before the string.

-                _mission_string += "{_trainer.name()} has proven themselves a great strategist when it comes to defensive structures beyond previousy known ";
+                _mission_string += $"{_trainer.name()} has proven themselves a great strategist when it comes to defensive structures beyond previousy known ";

Likely an incorrect or invalid review comment.

---

288-288: ⚠️ Potential issue

Missing sacred prefix '$' detected in string interpolation ritual.

The machine spirits cannot properly interpret the variable reference within the string template. The Omnissiah requires the '$' sigil to be present before the string.

-            _mission_string += "{_trainer.name()}s trained eye as a Siege Master also allowed him to make several improvements to the planets fortifications (fortification +1)";
+            _mission_string += $"{_trainer.name()}s trained eye as a Siege Master also allowed him to make several improvements to the planets fortifications (fortification +1)";

Likely an incorrect or invalid review comment.