Skip to content

fix: Train forces missionName print error #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OH296 merged 4 commits into from
May 5, 2025
Merged

fix: Train forces missionName print error #804

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
069b33f
fix name print add stat gain
OH296 May 4, 2025
fbd0222
Update scripts/scr_mission_functions/scr_mission_functions.gml
OH296 May 4, 2025
515033d
interpolation fix
OH296 May 4, 2025
a78d077
slightly kinder rewards
OH296 May 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions scripts/scr_mission_functions/scr_mission_functions.gml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,7 @@ function complete_train_forces_mission(targ_planet, problem_index){
var _mission_string = "";
var _trainer = collect_role_group("all",[name,targ_planet,0], false, man_conditions);
if (array_length(_trainer)){
var _unit_report_string = "";
var _tester = global.character_tester;
var _wis_test_difficulty = -20;
_trainer = _trainer[0];
Expand Down Expand Up @@ -284,10 +285,20 @@ function complete_train_forces_mission(targ_planet, problem_index){
var _new_pdf = planet.recruit_pdf((_unit_pass[1]/10));//this will approximate podf improvement for the time being
_mission_string += $"Training of the Pdf went well and improved the quality of the pdf as well as providing sizeable big recruitment improvement for the planet {_new_pdf} new pdf were recruited";
if (_siege_master){
_mission_string += "{_trainer.name()}s trained eye as a Siege Master also allowed him to make several improvements to the planets fortifications (fortification +1)";

_mission_string += $"{_trainer.name()}s trained eye as a Siege Master also allowed him to make several improvements to the planets fortifications (fortification +1)";
planet.alter_fortification(1);
}
} else {
if (roll_dice(1, 100) > 75 && _trainer.intelligence > 45){
_mission_string += $"{_trainer.name()} has proven themselves a great strategist when it comes to defensive structures beyond previousy known ";
var _start_stats = variable_clone(_trainer.get_stat_line());
_trainer.add_trait("siege_master");
var end_stat = _trainer.get_stat_line();
var _stat_diff = compare_stats(end_stat,_start_stats);
_unit_report_string += $"{_trainer.name_role()} Has gained the trait {global.trait_list.siege_master.display_name}, {(print_stat_diffs(_stat_diff))}\n";
_mission_string += "The new insights have allowed for minor improvements to planetary fortifications (fortification +1)";
planet.alter_fortification(1);
}
}
} else {
disp_loss = -5;
_mission_string += "The orgional training mission was a failiure"
Expand All @@ -314,7 +325,8 @@ function complete_train_forces_mission(targ_planet, problem_index){
}
planet.add_disposition(disp_loss);
}
scr_popup($"Training Forces on {planet_numeral_name(i)}",_mission_string,"","");
_mission_string += $"\n{_unit_report_string}";
scr_popup($"Training Forces on {planet.name()}",_mission_string,"","");
remove_planet_problem(targ_planet, "train_forces");
_trainer.job = "none";
}
Expand Down