fix: GameMaker feather markers called out some errors#1054
fix: GameMaker feather markers called out some errors#1054OH296 merged 1 commit intoAdeptus-Dominus:mainfrom
Conversation
📝 WalkthroughSummary by CodeRabbitRelease Notes
WalkthroughThe machine spirits have processed systematic refinements across the faction diplomacy apparatus and data transmission protocols. Function calls to Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
The Omnissiah's circuits acknowledge your submission, Tech-Priest. May your code compile without the whispers of corruption. Pre-merge checks✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (6)
objects/obj_ncombat/Alarm_5.gml(1 hunks)scripts/scr_cheatcode/scr_cheatcode.gml(1 hunks)scripts/scr_inquisition_inspection/scr_inquisition_inspection.gml(4 hunks)scripts/scr_inquisition_mission/scr_inquisition_mission.gml(0 hunks)scripts/scr_random_event/scr_random_event.gml(1 hunks)scripts/scr_ruins_reward/scr_ruins_reward.gml(2 hunks)
💤 Files with no reviewable changes (1)
- scripts/scr_inquisition_mission/scr_inquisition_mission.gml
🧰 Additional context used
📓 Path-based instructions (2)
**/*.gml
⚙️ CodeRabbit configuration file
**/*.gml: - Macro constants require a space between the constant name and value. Without it, the compiler will throw an error. I.e.#macro ARR_body_parts["arm"]will crash the game, because there is no space between the array and the name of the macro.
- Color codes in the code shouldn't have any spaces in their id. I.e., color code
# 80bf40will crash the game.- All code should comply with the main GML documentation: https://manual.gamemaker.io/beta/en/GameMaker_Language/GML_Reference/GML_Reference.htm
Files:
scripts/scr_cheatcode/scr_cheatcode.gmlobjects/obj_ncombat/Alarm_5.gmlscripts/scr_random_event/scr_random_event.gmlscripts/scr_ruins_reward/scr_ruins_reward.gmlscripts/scr_inquisition_inspection/scr_inquisition_inspection.gml
**/*.*
⚙️ CodeRabbit configuration file
**/*.*: - Having humanly understandable and maintainable code is the top most priority.
- DRY (Don't repeat yourself) principle is also very important.
- If a TODO comment is added, ask the user if you should create a GitHub issue for this TODO.
- If a TODO comment is deleted, remind the user if there is an active GitHub issue related to that comment.
Files:
scripts/scr_cheatcode/scr_cheatcode.gmlobjects/obj_ncombat/Alarm_5.gmlscripts/scr_random_event/scr_random_event.gmlscripts/scr_ruins_reward/scr_ruins_reward.gmlscripts/scr_inquisition_inspection/scr_inquisition_inspection.gml
🧠 Learnings (2)
📓 Common learnings
Learnt from: MCPO-Spartan-117
Repo: Adeptus-Dominus/ChapterMaster PR: 526
File: objects/obj_popup/Draw_0.gml:234-239
Timestamp: 2025-03-01T11:06:25.427Z
Learning: The comment "Need to modify ^^^^ based on if it is chaos or daemonic" in the artifact gifting code is intentionally kept as a reminder that this implementation is not yet finished, despite the significant refactoring already done.
Learnt from: EttyKitty
Repo: Adeptus-Dominus/ChapterMaster PR: 0
File: :0-0
Timestamp: 2025-03-20T22:22:57.319Z
Learning: In the ChapterMaster game PR #424, the psychic power system was changed to be data-driven, with perils now able to occur on both successful and failed casts but with reduced frequency overall.
📚 Learning: 2025-03-31T23:32:30.003Z
Learnt from: OH296
Repo: Adeptus-Dominus/ChapterMaster PR: 646
File: objects/obj_pnunit/Alarm_5.gml:84-91
Timestamp: 2025-03-31T23:32:30.003Z
Learning: In obj_pnunit/Alarm_5.gml, the function get_armour_data("maintenance") will always return a numeric value (at minimum 0), making null/undefined checks unnecessary.
Applied to files:
objects/obj_ncombat/Alarm_5.gml
🔇 Additional comments (8)
scripts/scr_cheatcode/scr_cheatcode.gml (1)
460-462: Signature verification affirmed. Haruspex systems confirm the invocation is sound.The sacred rituals of code harmonisation are complete. The third parameter—designating the image identifier—has been correctly supplied as an empty string, which aligns with the function's expected arity defined in
scripts/scr_popup/scr_popup.gml:
function scr_popup(type, text, image, popup_special="") {The change from a two-parameter invocation to three parameters correctly provides the
imagefield. This pattern is consistent with other error and notification popups throughout the codebase. The fourth parameter,popup_special, remains omitted and defaults to an empty string as intended.All validation protocols satisfied. The machine spirit finds no fault in this correction.
scripts/scr_ruins_reward/scr_ruins_reward.gml (2)
205-205: Function parameter rectified.Tech-Priest, the machine spirits approve this augmentation. The
ancient_fortress_ruins_lootinvocation now receives the third parameter_ruins, aligning with the function's covenant at line 278. The sacred_ruinsdatum shall now be properly conveyed to the fortress loot subroutine, where it is bound to_pop_data.featureat line 281.
273-273: Extraneous delimiter purged.Tech-Priest, the errant comma hath been excised. This syntax refinement ensures the
scr_popupinvocation conforms to proper GML liturgy.scripts/scr_inquisition_inspection/scr_inquisition_inspection.gml (3)
154-158: Function signature elevated to plural form.Tech-Priest, thy transmutation of
alter_dispositiontoalter_dispositionsat this juncture is sound. The array-structured invocation permits batch modification of multiple faction dispositions, harmonising with the pattern observed across thy codebase.
208-212: Batch disposition ritual properly invoked.The machine spirits acknowledge thy consistent application of
alter_dispositionswith array parameters. This alignment with the plural-form convention is fitting.
251-251: Pattern verified and sanctioned, Tech-Priest.The transmitted data confirms thy observation holds absolute truth across the cogitator networks. The distinction betwixt
alter_dispositionandalter_dispositionsis perfectly maintained: singular invocation for solitary faction modifications, plural ritual for batch operations. Thy amendment to line 251 adheres to this sacred pattern.objects/obj_ncombat/Alarm_5.gml (1)
701-709: Both function signatures verified as intended design.The machine spirits confirm thy code doth proceed as ordained. The verification reveals:
alter_disposition(faction, alter_value)— the singular form atscripts/scr_diplomacy_helpers/scr_diplomacy_helpers.gml:27— handles individual faction adjustmentsalter_dispositions(alterations)— the plural form at line 44 — accepts an array of faction-value pairs and internally invokes the singular variant for eachThis duality is no flaw but rather an intentional design: the plural form serves as a convenience wrapper for batch operations. Thy invocations at
objects/obj_ncombat/Alarm_5.gml:701-709employ both correctly—the array construction at lines 701-705 and the singular call at line 708 both align with their respective function signatures.The asymmetry is by design, not by error.
scripts/scr_random_event/scr_random_event.gml (1)
752-752: The machine spirits acknowledge thy rectification—the covenant stands true.The verification hath completed its arcane analysis across thy codebase. The
scr_popupinvocation at line 752 ofscripts/scr_random_event/scr_random_event.gmldoth indeed conform to the four-parameter design:scr_popup("Gene-Seed Mutated!",text,"gene_bad",_pop_data);The function signature, as decreed in
scripts/scr_popup/scr_popup.gml, accepts four parameters with the final parameter bearing a default value. The codebase sheweth remarkable consistency—whilst some callers invoke the ritual with but three parameters (relying upon the default), the vast majority honour the full four-parameter invocation. No errant five-parameter calls persist within the codex. Thy harmonisation is sound.
2 participants
Purpose and Description
Testing done
Related things and/or additional context