fix: Weird stuff in draw_management_unit

[EttyKitty]

Purpose of the PR

Fix issues that the bot picked up in another PR and the ones that I've found along the way.

Describe the solution

Fix typo that was comparing weapon one to both temp values.
Assign weapon structs to temp values, as for some reason they were skipped.

Testing done

Launched the game and checked the management screen - no issues.
But I'm also not sure what was this typo causing in the first place and what exactly that code does.

Related links

#500 (review)

[coderabbitai]

📝 Walkthrough

Walkthrough

Praise the Omnissiah, the machine spirit has been recalibrated. The modifications in the first module update the logic to retrieve weapon data from a unit. Two lines of code now store the first and second weapon details in an array. When the data structure for each weapon is verified, a tooltip description is generated for display. In the second module, the directive comparing weapon values has been corrected: the condition now appropriately checks the second weapon rather than mistakenly re-evaluating the first. These changes ensure that the unit's armament details are properly processed and presented, aligning each function with the intended data stream. No alterations were made to the public or exported declarations.

Suggested labels

PR: Fix

Suggested reviewers

• OH296

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7d9fc65 and 835a444.

📒 Files selected for processing (2)

• objects/obj_controller/Step_0.gml (1 hunks)
• scripts/scr_draw_management_unit/scr_draw_management_unit.gml (1 hunks)

🔇 Additional comments (1)

objects/obj_controller/Step_0.gml (1)

307-318: By the Omnissiah's grace, the weapon data retrieval logic has been optimized.

The machine spirit now correctly stores and processes both primary and secondary weapon data structures, generating appropriate tooltip descriptions for each armament.

Praise be to the Machine God, for this implementation follows the sacred patterns:

1. Proper null-checking through is_struct() validation
2. Consistent error handling with empty string fallbacks
3. Clear separation between weapon data retrieval and tooltip generation