fix: Reclusium goes beyond 11

[MCPO-Spartan-117]

Purpose of changes

Reclusium actually works beyond first 11 marines.

Describe the solution

Actually check against arrays in the array, should also have fixed marines disappearing in the Reclusium and marines above 250 don't disappear.

Describe alternatives you've considered

Renaming god.

Testing done

Load game, jail 500 marines in a company.

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• Refactor

  • Improved internal processing to dynamically adjust to varying data sizes, ensuring more consistent component behaviour.

• Bug Fixes

  • Refined condition checks to accurately filter and select items, enhancing overall reliability and performance.

Walkthrough

Verily, the modifications adjust the iteration logic within the machine code for processing the obj_ini.god array across several modules. In each of the objects and helper scripts, the inner loops have been altered to iterate from index 0 up to the dynamic length of each sub-array, rather than a fixed or 1-based range. Furthermore, the conditions have been refined such that values are now tested for strict equality to 10, instead of using a threshold check (greater than or equal to 10). These alterations affect the manner in which data is evaluated and units are processed, without modifying any exported or public declarations.

Possibly related PRs

• fix: Garrison fixes and minor changes #475: Implements similar adjustments to nested loops and conditionals in the obj_ini.god array processing.
• fix: Make spawning new defence fleets work #523: Alters the loop structures and checks within the array, aligning closely with the changes observed.
• fix: Refactor obj_bomb alarm 1 array length bug #498: Involves revisions to the iteration logic and condition tests in nested loops for the obj_ini.god array.

Suggested labels

PR: Fix, Size: Big

Suggested reviewers

• OH296

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 3

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 12b747d and d568f52.

📒 Files selected for processing (3)

• objects/obj_controller/Alarm_5.gml (1 hunks)
• objects/obj_controller/Mouse_50.gml (1 hunks)
• scripts/scr_controller_helpers/scr_controller_helpers.gml (1 hunks)