fix: Save new formations and rename

[MCPO-Spartan-117]

Purpose of changes

Fix #549

Describe the solution

Saving properly.

Testing done

Load game, Save game, Load game.

Related links

https://discord.com/channels/714022226810372107/1347896006657835089

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• New Features
  • Enhanced formation options have been introduced. The previous formation selection has been updated to offer three distinct choices—landraid, landspee, and whirl—for increased variety and customisation.

Walkthrough

The changes pertain to two controller scripts. In the scr_load_controller.gml, two lines have been reformatted by replacing tab characters with spaces when assigning values to obj_controller.bat_landspee_for and obj_controller.bat_whirl_for, while the logic remains unaltered. In the scr_save_controller.gml, the former encoding of the "land" formation using obj_controller.bat_land_for has been removed. This deletion is replaced by three new encoding calls handling the “landraid”, “landspee”, and “whirl” formations respectively. There are no changes to any public or exported entity declarations.

Possibly related PRs

• fix: #500 breakage #506: This pull request involves modifications concerning the obj_controller.bat_landspee_for variable, which directly relates to the changes made in both the load and save controller scripts.

Suggested labels

PR: Fix

Suggested reviewers

• OH296

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f433c42 and 078d31d.

📒 Files selected for processing (2)

• scripts/scr_load_controller/scr_load_controller.gml (1 hunks)
• scripts/scr_save_controller/scr_save_controller.gml (1 hunks)

🔇 Additional comments (1)

scripts/scr_load_controller/scr_load_controller.gml (1)

186-187: Proper alignment of the sacred data acquisition rituals.

The Machine Spirit acknowledges these formatting alterations. The indentation has been properly aligned for the loading of battle formation data structures for the Land Speeder and Whirlwind patterns, ensuring accurate data retrieval from the blessed storage arrays.