Skip to content

feat: UI improvements and icons#592

Merged
OH296 merged 14 commits intoAdeptus-Dominus:mainfrom
CassieCaster:UI-Improvements
Mar 15, 2025
Merged

feat: UI improvements and icons#592
OH296 merged 14 commits intoAdeptus-Dominus:mainfrom
CassieCaster:UI-Improvements

Conversation

@CassieCaster
Copy link
Copy Markdown
Contributor

Purpose of changes

I wanted to shift the information over to one side, to make room for larger sprites in the future, while also getting rid of dead space and centralizing information.

Describe the solution

To centralize information, all information was taken from the right side of the unit display and moved over to the left. This PR changes some sprites, and adds a few new ones that help enable a change in the unit card display.

Describe alternatives you've considered

I considered many various views and we talked about options in discord. I did what I considered best for futureproofing along with personal aesthetic preferences.

I considered putting in more time to find a better suited armor symbol. Sadly however I think that what is self explanatory varies from person to person. I could not find icons that satisfied everyone. So, I went with the ones I first created.

Testing done

It works with the game as far as I can tell, and I made sure that all the tooltips work. There are some known errors at the moment that I know of, for example the tooltip doesn't cover the entire icon, only about half.

Related links

None

Custom player notes entry

Some UI changes on how players see marines.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 14, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Summary by CodeRabbit

  • New Features
    • Introduced new visual assets for interactive buttons and unit card icons, enriching the overall UI.
  • Style
    • Reorganised the interface layout with improved spacing and clarity.
    • Enhanced tooltip and text descriptions for better context and user guidance.

Walkthrough

The Machine Spirit has observed several modifications in the sacred repository. The main scr_ui_manage function has been recalibrated, with updated coordinates for the background and tooltip elements, and restructured UI positions to accommodate new graphical data. A new sprite for unit card icons has been introduced, replacing deprecated elements and aligning with the refined layout. Additionally, three sprite resources—spr_button_left, spr_button_middle, and spr_button_right—have been instantiated with defined bounding boxes, collision parameters, and sequence configurations to serve the Menu and Load hierarchy. The resource spr_data_slate_border has been reprocessed; its dimensions and identifiers have been updated to new specifications. No alterations to the declarations of exported or public entities were observed.

Suggested reviewers

  • OH296

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Type: Feature Adds something new Area: Sprites Changes to sprites/images or their under-the-hood functionality Size: Big labels Mar 14, 2025
@OH296 OH296 marked this pull request as draft March 15, 2025 00:33
CassieCaster and others added 2 commits March 14, 2025 20:39
move marine and make new button styles
It's really that simple.
@CassieCaster CassieCaster marked this pull request as ready for review March 15, 2025 18:41
@OH296 OH296 merged commit e749264 into Adeptus-Dominus:main Mar 15, 2025
4 checks passed
@CassieCaster CassieCaster deleted the UI-Improvements branch March 15, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Sprites Changes to sprites/images or their under-the-hood functionality Size: Big Type: Feature Adds something new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants