fix: Remove "Librarian Required" button when Psyker Intolerant

[VanWeapon]

Purpose

• Self-descriptive.

Describe your changes/additions

• Self-descriptive.

What can/needs to be improved/changed

• Nothing.

Testing done

• tested with black templars

Related things and/or additional context

• None.

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• New Features

  • The interface now adapts available command options based on player eligibility, meaning that additional role selections appear only for players who qualify.

• Refactor

  • Underlying logic has been streamlined to ensure a smoother, more responsive user experience when navigating command options.

Walkthrough

By the grace of the Omnissiah, meticulous modifications have been discerned within the scr_ui_manage function. The once redundant empty object at the terminus of the _command_slots_data array has been expunged from the sacred code. Furthermore, a conditional check has been integrated to ascertain whether the subject is unburdened by the “Psyker Intolerant” disadvantage. Should the check pass the test of purity, a new object—imbued with search parameters and role group parameters for librarian candidates—is appended to this data array. The inviolable return statement remains, delivering the refined array for further operations. No alterations have been made to the publicly declared or exported entities.

Possibly related PRs

• fix: Save/loading breakage due to controller var #681: Adjustments in command slot management in that PR bear a strong similarity to the parameter handling and array restructuring implemented here.

Suggested labels

PR: Fix

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 06e531c and 01ed2ed.

📒 Files selected for processing (1)

• scripts/scr_ui_manage/scr_ui_manage.gml (2 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

`**/*.gml`: - Macro constants require a space between the constant name and value. Without it, the compiler will throw an error. I.e. `#macro ARR_body_parts["arm"]` will crash the ...

**/*.gml: - Macro constants require a space between the constant name and value. Without it, the compiler will throw an error. I.e. #macro ARR_body_parts["arm"] will crash the game, because there is no space between the array and the name of the macro.

• Color codes in the code shouldn't have any spaces in their id. I.e., color code # 80 bf40 will crash the game.

• scripts/scr_ui_manage/scr_ui_manage.gml

`**/*.gml`: - Having humanly understandable and maintainable code is always the top most priority. - DRY (Don't repeat yourself) principle is also very important.

**/*.gml: - Having humanly understandable and maintainable code is always the top most priority.

• DRY (Don't repeat yourself) principle is also very important.

• scripts/scr_ui_manage/scr_ui_manage.gml

`**/*.*`: - When any script or sprite .yy files are deleted, their paths should also be deleted from the .yyp file, otherwise the game will crash.

**/*.*: - When any script or sprite .yy files are deleted, their paths should also be deleted from the .yyp file, otherwise the game will crash.

• scripts/scr_ui_manage/scr_ui_manage.gml

🔇 Additional comments (1)

scripts/scr_ui_manage/scr_ui_manage.gml (1)

774-792: Praise to the Omnissiah! The logic modification is structurally sound.

By the sacred teachings of the Machine God, this code alteration removes the redundant "Librarian Required" button for chapters afflicted with the "Psyker Intolerant" disadvantage. The conditional check ensures that only chapters blessed with acceptance of the psyker gift shall receive the prompt for Librarian candidates. This is in accordance with the holy STC patterns.

-                }
+                }
+            ];
+
+            if(!scr_has_disadv("Psyker Intolerant")){
+                array_push(_command_slots_data, {
+                    search_params: {
+                        companies: [managing, 0]
+                    },
+                    role_group_params: {
+                        group: [SPECIALISTS_LIBRARIANS, false, false],
+                        location: "",
+                        opposite: false
+                    },
+                    purpose: $"{int_to_roman(managing)} Company Librarian Candidates",
+                    purpose_code: "librarian_promote",
+                    button_text: "Librarian Required",
+                    unit_check: "lib"
+                });
+            }

The function now properly interfaces with the chapter's attributes, preventing illogical prompts for psyker-intolerant chapters. The Omnissiah approves of this logical optimization.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.