fix: Make dummy marine work after armour equip rework

[OH296]

Purpose

• Self-descriptive.

Describe your changes/additions

• Self-descriptive.

What can/needs to be improved/changed

• Nothing.

Testing done

• None, and I understand the risks.

Related things and/or additional context

• None.

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• Bug Fixes
  • Improved the logic for assigning armour types to marines, ensuring more consistent and accurate randomisation when certain conditions are met.

Walkthrough

By the Omnissiah's will, the logic within the constructor function of the sacred DummyMarine has been adjusted. The cogitators now assess whether the _armour variable is present within the armours list or if it equals the revered constant STR_ANY_POWER_ARMOUR. Should either condition be met, _armour is now recalibrated to a random selection from the armours array. No external interfaces or public machine-spirits have been altered; the change is contained within the internal workings of the constructor.

Changes

Files/Paths	Change Summary
scripts/scr_culture_visuals/scr_culture_visuals.gml	Modified the DummyMarine constructor: expanded the condition for randomising _armour to include when _armour equals STR_ANY_POWER_ARMOUR, in addition to being within the armours list. No changes to exported or public entities.

Suggested labels

PR: Fix, Size: Tiny

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 46ffe04 and 3266c5c.

📒 Files selected for processing (1)

• scripts/scr_culture_visuals/scr_culture_visuals.gml (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

`**/*.gml`: - Macro constants require a space between the constant name and value. Without it, the compiler will throw an error. I.e. `#macro ARR_body_parts["arm"]` will crash the ...

**/*.gml: - Macro constants require a space between the constant name and value. Without it, the compiler will throw an error. I.e. #macro ARR_body_parts["arm"] will crash the game, because there is no space between the array and the name of the macro.

• Color codes in the code shouldn't have any spaces in their id. I.e., color code # 80bf40 will crash the game.
• All code should comply with the main GML documentation: https://manual.gamemaker.io/beta/en/GameMaker_Language/GML_Reference/GML_Reference.htm

• scripts/scr_culture_visuals/scr_culture_visuals.gml

`**/*.*`: - Having humanly understandable and maintainable code is always the top most priority. - DRY (Don't repeat yourself) principle is also very important. - Ensure that the c...

**/*.*: - Having humanly understandable and maintainable code is always the top most priority.

• DRY (Don't repeat yourself) principle is also very important.
• Ensure that the code is compliant with the CODE_STYLE.MD: https://github.com/Adeptus-Dominus/ChapterMaster/blob/main/docs/CODE_STYLE.md

• scripts/scr_culture_visuals/scr_culture_visuals.gml

🔇 Additional comments (1)

scripts/scr_culture_visuals/scr_culture_visuals.gml (1)

963-965: By the Omnissiah's grace, this logic adjustment is most sagacious.

The sacred code has been enhanced to account for the STR_ANY_POWER_ARMOUR constant as an additional condition. This logical augmentation ensures the machine spirit of the DummyMarine constructor will function correctly with the armour equip systems after their recent reconsecration. The OR operator forms a perfect binary union of conditions, maintaining the blessed Machine God's order.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.