fix: Cata fixes and Serpha V jump pack.#915
Conversation
github-actions
bot
added
Area: Sprites
📝 WalkthroughSummary by CodeRabbit
WalkthroughBy the Omnissiah’s will, this update introduces the "Ancient Jump Pack" as a new mobility item across the armoury, shop, loot, and reward systems. Modular drawing logic and new sprites are integrated for accurate visual representation. Numerous Cataphractii-related sprite origins are recalibrated for proper alignment. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🔭 Outside diff range comments (1)
scripts/scr_culture_visuals/scr_culture_visuals.gml (1)
1188-1222: Syntax corruption detected in the sacred texts.Critical formatting and structural anomalies observed:
- Duplicate
subcomponentsdeclarations (lines 1188 and 1197)- Malformed
overidesstructure with missing closing braces- Inconsistent indentation disrupting code sanctity
Apply this ritual of correction:
- subcomponents : [ - [spr_blank, spr_cata_shoulder_hanging_leather_right_tips], - ], - overides: { - "left_pauldron_embeleshments" : - spr_cata_shoulder_hanging_leather_left, - "tabbard": - spr_cata_tabbard_leather - }, - subcomponents : [ - [spr_blank, spr_cata_shoulder_hanging_leather_right_tips], - ], + subcomponents : [ + [spr_blank, spr_cata_shoulder_hanging_leather_right_tips], + ], + overides: { + "left_pauldron_embeleshments": spr_cata_shoulder_hanging_leather_left, + "tabbard": spr_cata_tabbard_leather + },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (22)
sprites/spr_cata_complex/2583c501-d4e3-4285-b210-347ae21d5657.pngis excluded by!**/*.pngsprites/spr_cata_complex/layers/2583c501-d4e3-4285-b210-347ae21d5657/1c6df36d-e885-4b8f-a400-731ba5f7a89f.pngis excluded by!**/*.pngsprites/spr_cata_cowl_trim_1/eacd6626-c655-4103-80b3-501d635dbecc.pngis excluded by!**/*.pngsprites/spr_cata_cowl_trim_1/layers/eacd6626-c655-4103-80b3-501d635dbecc/19bbd962-0cda-4b64-9afc-f12938f1660e.pngis excluded by!**/*.pngsprites/spr_cata_gorget/d14dc785-21d1-4e15-ad83-2b38fa9a79f7.pngis excluded by!**/*.pngsprites/spr_cata_gorget/layers/d14dc785-21d1-4e15-ad83-2b38fa9a79f7/fe0dd4fc-c973-4418-9c16-c69e04260f36.pngis excluded by!**/*.pngsprites/spr_cata_head/cc1bb055-3092-4530-9edd-694aca0796a7.pngis excluded by!**/*.pngsprites/spr_cata_head/df8d27d6-66e9-4750-b0dc-950fe74d3e9f.pngis excluded by!**/*.pngsprites/spr_cata_head/layers/cc1bb055-3092-4530-9edd-694aca0796a7/1875f065-a467-43e5-b1cb-779c58891acc.pngis excluded by!**/*.pngsprites/spr_cata_head/layers/df8d27d6-66e9-4750-b0dc-950fe74d3e9f/1875f065-a467-43e5-b1cb-779c58891acc.pngis excluded by!**/*.pngsprites/spr_cata_left_leg/30845d03-5630-4ea2-b874-e43d1c591f74.pngis excluded by!**/*.pngsprites/spr_cata_left_leg/layers/30845d03-5630-4ea2-b874-e43d1c591f74/c2171e14-c3fe-4232-ba2e-e302118f9cc4.pngis excluded by!**/*.pngsprites/spr_cata_shoulder_hanging_leather_left_tips/3d17787f-c1c2-47db-992e-a221a37550a1.pngis excluded by!**/*.pngsprites/spr_cata_shoulder_hanging_leather_left_tips/layers/3d17787f-c1c2-47db-992e-a221a37550a1/89d15f31-c097-44dc-98f3-b3d5ed35463c.pngis excluded by!**/*.pngsprites/spr_cata_shoulder_hanging_leather_right/0eb5da06-be9b-42af-a45c-5652a70e0363.pngis excluded by!**/*.pngsprites/spr_cata_shoulder_hanging_leather_right/layers/0eb5da06-be9b-42af-a45c-5652a70e0363/240582c2-092d-40fa-9caa-ea64c5a2fc69.pngis excluded by!**/*.pngsprites/spr_cata_tabbard_leather_hangings/16ff2f35-0659-40fa-be7a-7a2942a2c47e.pngis excluded by!**/*.pngsprites/spr_cata_tabbard_leather_hangings/layers/16ff2f35-0659-40fa-be7a-7a2942a2c47e/a8907230-deee-4373-af6a-ec8ca94f1d81.pngis excluded by!**/*.pngsprites/spr_jump_pack_serpha_complex/bf0c5f8b-3023-4fe2-8b02-193bc2c05b25.pngis excluded by!**/*.pngsprites/spr_jump_pack_serpha_complex/layers/bf0c5f8b-3023-4fe2-8b02-193bc2c05b25/44bab4d0-aab6-43b3-8549-2f4f4dc0ef03.pngis excluded by!**/*.pngsprites/spr_weapon_volkite_culverin_term/175b3fc0-27ea-4b35-bab7-7867c6fa811b.pngis excluded by!**/*.pngsprites/spr_weapon_volkite_culverin_term/layers/175b3fc0-27ea-4b35-bab7-7867c6fa811b/929a717e-45ba-45eb-915b-7e0136b8f8d3.pngis excluded by!**/*.png
📒 Files selected for processing (38)
objects/obj_shop/Create_0.gml(1 hunks)scripts/scr_culture_visuals/scr_culture_visuals.gml(5 hunks)scripts/scr_initialize_custom/scr_initialize_custom.gml(1 hunks)scripts/scr_ruins_reward/scr_ruins_reward.gml(1 hunks)scripts/scr_weapon/scr_weapon.gml(1 hunks)sprites/spr_cata_belt/spr_cata_belt.yy(2 hunks)sprites/spr_cata_complex/spr_cata_complex.yy(2 hunks)sprites/spr_cata_cowl_trim/spr_cata_cowl_trim.yy(2 hunks)sprites/spr_cata_cowl_trim_1/spr_cata_cowl_trim_1.yy(1 hunks)sprites/spr_cata_gorget/spr_cata_gorget.yy(2 hunks)sprites/spr_cata_head/spr_cata_head.yy(2 hunks)sprites/spr_cata_heavy_toe_left/spr_cata_heavy_toe_left.yy(2 hunks)sprites/spr_cata_heavy_toe_right/spr_cata_heavy_toe_right.yy(2 hunks)sprites/spr_cata_left_arm/spr_cata_left_arm.yy(2 hunks)sprites/spr_cata_left_armtrim/spr_cata_left_armtrim.yy(2 hunks)sprites/spr_cata_left_knee/spr_cata_left_knee.yy(2 hunks)sprites/spr_cata_left_leg/spr_cata_left_leg.yy(2 hunks)sprites/spr_cata_left_trim/spr_cata_left_trim.yy(2 hunks)sprites/spr_cata_left_trim_1/spr_cata_left_trim_1.yy(2 hunks)sprites/spr_cata_left_trim_2/spr_cata_left_trim_2.yy(2 hunks)sprites/spr_cata_right_arm/spr_cata_right_arm.yy(2 hunks)sprites/spr_cata_right_armtrim/spr_cata_right_armtrim.yy(2 hunks)sprites/spr_cata_right_knee/spr_cata_right_knee.yy(2 hunks)sprites/spr_cata_right_leg/spr_cata_right_leg.yy(2 hunks)sprites/spr_cata_right_trim/spr_cata_right_trim.yy(2 hunks)sprites/spr_cata_right_trim_1/spr_cata_right_trim_1.yy(2 hunks)sprites/spr_cata_right_trim_2/spr_cata_right_trim_2.yy(2 hunks)sprites/spr_cata_shoulder_hanging_leather_left/spr_cata_shoulder_hanging_leather_left.yy(2 hunks)sprites/spr_cata_shoulder_hanging_leather_left_tips/spr_cata_shoulder_hanging_leather_left_tips.yy(2 hunks)sprites/spr_cata_shoulder_hanging_leather_right/spr_cata_shoulder_hanging_leather_right.yy(2 hunks)sprites/spr_cata_shoulder_hanging_leather_right_tips/spr_cata_shoulder_hanging_leather_right_tips.yy(2 hunks)sprites/spr_cata_shoulder_hanging_mail_left/spr_cata_shoulder_hanging_mail_left.yy(2 hunks)sprites/spr_cata_shoulder_hanging_mail_right/spr_cata_shoulder_hanging_mail_right.yy(2 hunks)sprites/spr_cata_tabbard_leather/spr_cata_tabbard_leather.yy(2 hunks)sprites/spr_cata_tabbard_leather_hangings/spr_cata_tabbard_leather_hangings.yy(2 hunks)sprites/spr_cata_tabbard_mail/spr_cata_tabbard_mail.yy(2 hunks)sprites/spr_jump_pack_serpha_complex/spr_jump_pack_serpha_complex.yy(1 hunks)sprites/spr_weapon_volkite_culverin_term/spr_weapon_volkite_culverin_term.yy(1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.gml
Instructions used from:
Sources:
⚙️ CodeRabbit Configuration File
**/*.*
Instructions used from:
Sources:
⚙️ CodeRabbit Configuration File
**/*.yy
Instructions used from:
Sources:
⚙️ CodeRabbit Configuration File
🧠 Learnings (39)
📓 Common learnings
Learnt from: EttyKitty
PR: Adeptus-Dominus/ChapterMaster#0
File: :0-0
Timestamp: 2025-04-05T20:54:45.813Z
Learning: EttyKitty requested a rework of the vehicle and marine recovery system in ChapterMaster. The current system allows guaranteed recovery with enough recovery points, while the proposed system would use random chance modified by techmarine skill and item bonuses.
Learnt from: EttyKitty
PR: Adeptus-Dominus/ChapterMaster#0
File: :0-0
Timestamp: 2025-03-20T22:22:57.319Z
Learning: In the ChapterMaster game PR #424, the psychic power system was changed to be data-driven, with perils now able to occur on both successful and failed casts but with reduced frequency overall.
Learnt from: EttyKitty
PR: Adeptus-Dominus/ChapterMaster#0
File: :0-0
Timestamp: 2025-03-20T22:22:57.319Z
Learning: In the ChapterMaster game PR #424, the "Psyker Abundance" advantage was renamed to "Warp Touched", "Daemon Binders" advantage was removed, and "Warp Touched" disadvantage was renamed to "Warp Tainted".
Learnt from: EttyKitty
PR: Adeptus-Dominus/ChapterMaster#0
File: :0-0
Timestamp: 2025-03-20T22:22:57.319Z
Learning: In the ChapterMaster game PR #424, the combat log was expanded to display up to 24 messages instead of 8, providing more detailed battle information.
Learnt from: MCPO-Spartan-117
PR: Adeptus-Dominus/ChapterMaster#526
File: objects/obj_popup/Draw_0.gml:234-239
Timestamp: 2025-03-01T11:06:25.427Z
Learning: The comment "Need to modify ^^^^ based on if it is chaos or daemonic" in the artifact gifting code is intentionally kept as a reminder that this implementation is not yet finished, despite the significant refactoring already done.
scripts/scr_ruins_reward/scr_ruins_reward.gml (5)
Learnt from: EttyKitty
PR: Adeptus-Dominus/ChapterMaster#647
File: scripts/scr_en_weapon/scr_en_weapon.gml:24-928
Timestamp: 2025-03-29T10:30:25.598Z
Learning: A data-driven approach for weapon management in `scripts/scr_en_weapon/scr_en_weapon.gml` is planned for a future PR, not within the scope of PR #647.
Learnt from: EttyKitty
PR: Adeptus-Dominus/ChapterMaster#0
File: :0-0
Timestamp: 2025-04-05T20:58:21.881Z
Learning: In the ChapterMaster game, there's a need to refactor hardcoded item effects and move them to a "specials" property of items, following the pattern established with the `combi_tool` special. This improves code maintainability and makes effects more explicit in item definitions.
Learnt from: EttyKitty
PR: Adeptus-Dominus/ChapterMaster#0
File: :0-0
Timestamp: 2025-04-05T20:58:21.881Z
Learning: In the ChapterMaster game, there's a need to refactor hardcoded item effects and move them to a "specials" property of items, following the pattern established with the `combi_tool` special. This improves code maintainability and makes effects more explicit in item definitions.
Learnt from: MCPO-Spartan-117
PR: Adeptus-Dominus/ChapterMaster#526
File: objects/obj_popup/Draw_0.gml:234-239
Timestamp: 2025-03-01T11:06:25.427Z
Learning: The comment "Need to modify ^^^^ based on if it is chaos or daemonic" in the artifact gifting code is intentionally kept as a reminder that this implementation is not yet finished, despite the significant refactoring already done.
Learnt from: MCPO-Spartan-117
PR: Adeptus-Dominus/ChapterMaster#554
File: objects/obj_popup/Step_0.gml:756-767
Timestamp: 2025-03-06T16:02:06.286Z
Learning: The variable 'woopwoopwoop' in ancient ruins exploration code is a poorly named boolean flag that controls the flow between detecting a battle in ruins and initiating the combat sequence.
sprites/spr_cata_left_knee/spr_cata_left_knee.yy (1)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
sprites/spr_cata_tabbard_mail/spr_cata_tabbard_mail.yy (1)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
sprites/spr_cata_right_arm/spr_cata_right_arm.yy (1)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
sprites/spr_cata_right_knee/spr_cata_right_knee.yy (1)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
sprites/spr_cata_complex/spr_cata_complex.yy (1)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
sprites/spr_cata_shoulder_hanging_leather_right/spr_cata_shoulder_hanging_leather_right.yy (1)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
sprites/spr_cata_right_trim_2/spr_cata_right_trim_2.yy (1)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
sprites/spr_cata_belt/spr_cata_belt.yy (1)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
sprites/spr_cata_right_leg/spr_cata_right_leg.yy (1)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
sprites/spr_cata_shoulder_hanging_mail_left/spr_cata_shoulder_hanging_mail_left.yy (1)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
sprites/spr_cata_shoulder_hanging_leather_left/spr_cata_shoulder_hanging_leather_left.yy (1)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
sprites/spr_cata_tabbard_leather/spr_cata_tabbard_leather.yy (1)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
sprites/spr_cata_shoulder_hanging_leather_left_tips/spr_cata_shoulder_hanging_leather_left_tips.yy (3)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
Learnt from: EttyKitty
PR: Adeptus-Dominus/ChapterMaster#878
File: scripts/scr_culture_visuals/scr_culture_visuals.gml:1256-1352
Timestamp: 2025-06-16T17:12:13.045Z
Learning: In scripts/scr_culture_visuals/scr_culture_visuals.gml, the weapon visual data declarations contain known DRY violations that are acknowledged by the development team but deferred to future refactoring efforts rather than addressed in individual feature PRs.
Learnt from: EttyKitty
PR: Adeptus-Dominus/ChapterMaster#878
File: scripts/scr_culture_visuals/scr_culture_visuals.gml:1256-1352
Timestamp: 2025-06-16T17:12:13.045Z
Learning: In scripts/scr_culture_visuals/scr_culture_visuals.gml, the weapon visual data declarations contain known DRY violations that are acknowledged by the development team but deferred to future refactoring efforts rather than addressed in individual feature PRs.
sprites/spr_cata_heavy_toe_right/spr_cata_heavy_toe_right.yy (1)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
sprites/spr_cata_gorget/spr_cata_gorget.yy (1)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
sprites/spr_cata_cowl_trim/spr_cata_cowl_trim.yy (1)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
sprites/spr_cata_right_armtrim/spr_cata_right_armtrim.yy (1)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
sprites/spr_cata_head/spr_cata_head.yy (1)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
sprites/spr_cata_shoulder_hanging_leather_right_tips/spr_cata_shoulder_hanging_leather_right_tips.yy (1)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
sprites/spr_cata_right_trim_1/spr_cata_right_trim_1.yy (1)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
sprites/spr_cata_left_trim/spr_cata_left_trim.yy (1)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
objects/obj_shop/Create_0.gml (3)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#902
File: objects/obj_shop/Create_0.gml:550-655
Timestamp: 2025-07-01T20:29:44.075Z
Learning: In GML shop item initialization code, when setting nobuy flags for shop items, the nobuy[i] = 1 assignment must occur before incrementing the index (i += 1). Setting nobuy after incrementing i will apply the flag to the wrong item, potentially making restricted items purchasable or blocking intended purchasable items.
Learnt from: EttyKitty
PR: Adeptus-Dominus/ChapterMaster#0
File: :0-0
Timestamp: 2025-04-05T20:58:21.881Z
Learning: In the ChapterMaster game, there's a need to refactor hardcoded item effects and move them to a "specials" property of items, following the pattern established with the `combi_tool` special. This improves code maintainability and makes effects more explicit in item definitions.
Learnt from: EttyKitty
PR: Adeptus-Dominus/ChapterMaster#0
File: :0-0
Timestamp: 2025-04-05T20:58:21.881Z
Learning: In the ChapterMaster game, there's a need to refactor hardcoded item effects and move them to a "specials" property of items, following the pattern established with the `combi_tool` special. This improves code maintainability and makes effects more explicit in item definitions.
sprites/spr_cata_left_trim_1/spr_cata_left_trim_1.yy (1)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
sprites/spr_cata_left_arm/spr_cata_left_arm.yy (1)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
sprites/spr_cata_tabbard_leather_hangings/spr_cata_tabbard_leather_hangings.yy (1)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
sprites/spr_cata_left_leg/spr_cata_left_leg.yy (1)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
sprites/spr_cata_right_trim/spr_cata_right_trim.yy (1)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
sprites/spr_weapon_volkite_culverin_term/spr_weapon_volkite_culverin_term.yy (3)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
Learnt from: EttyKitty
PR: Adeptus-Dominus/ChapterMaster#878
File: scripts/scr_culture_visuals/scr_culture_visuals.gml:1256-1352
Timestamp: 2025-06-16T17:12:13.045Z
Learning: In scripts/scr_culture_visuals/scr_culture_visuals.gml, the weapon visual data declarations contain known DRY violations that are acknowledged by the development team but deferred to future refactoring efforts rather than addressed in individual feature PRs.
Learnt from: EttyKitty
PR: Adeptus-Dominus/ChapterMaster#878
File: scripts/scr_culture_visuals/scr_culture_visuals.gml:1256-1352
Timestamp: 2025-06-16T17:12:13.045Z
Learning: In scripts/scr_culture_visuals/scr_culture_visuals.gml, the weapon visual data declarations contain known DRY violations that are acknowledged by the development team but deferred to future refactoring efforts rather than addressed in individual feature PRs.
sprites/spr_cata_left_trim_2/spr_cata_left_trim_2.yy (1)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
scripts/scr_initialize_custom/scr_initialize_custom.gml (6)
Learnt from: VanWeapon
PR: Adeptus-Dominus/ChapterMaster#725
File: scripts/scr_initialize_custom/scr_initialize_custom.gml:956-959
Timestamp: 2025-04-15T11:07:33.927Z
Learning: Negative vehicle counts (like `rhino -= 2` potentially resulting in negative values) are acceptable in the `scr_initialize_custom` function, particularly when handling chapter advantages like "Lightning Warriors". This is intentional behavior in the game's design.
Learnt from: EttyKitty
PR: Adeptus-Dominus/ChapterMaster#647
File: scripts/scr_en_weapon/scr_en_weapon.gml:24-928
Timestamp: 2025-03-29T10:30:25.598Z
Learning: A data-driven approach for weapon management in `scripts/scr_en_weapon/scr_en_weapon.gml` is planned for a future PR, not within the scope of PR #647.
Learnt from: EttyKitty
PR: Adeptus-Dominus/ChapterMaster#0
File: :0-0
Timestamp: 2025-04-05T20:58:21.881Z
Learning: In the ChapterMaster game, there's a need to refactor hardcoded item effects and move them to a "specials" property of items, following the pattern established with the `combi_tool` special. This improves code maintainability and makes effects more explicit in item definitions.
Learnt from: EttyKitty
PR: Adeptus-Dominus/ChapterMaster#0
File: :0-0
Timestamp: 2025-04-05T20:58:21.881Z
Learning: In the ChapterMaster game, there's a need to refactor hardcoded item effects and move them to a "specials" property of items, following the pattern established with the `combi_tool` special. This improves code maintainability and makes effects more explicit in item definitions.
Learnt from: EttyKitty
PR: Adeptus-Dominus/ChapterMaster#878
File: scripts/scr_culture_visuals/scr_culture_visuals.gml:1256-1352
Timestamp: 2025-06-16T17:12:13.045Z
Learning: In scripts/scr_culture_visuals/scr_culture_visuals.gml, the weapon visual data declarations contain known DRY violations that are acknowledged by the development team but deferred to future refactoring efforts rather than addressed in individual feature PRs.
Learnt from: EttyKitty
PR: Adeptus-Dominus/ChapterMaster#878
File: scripts/scr_culture_visuals/scr_culture_visuals.gml:1256-1352
Timestamp: 2025-06-16T17:12:13.045Z
Learning: In scripts/scr_culture_visuals/scr_culture_visuals.gml, the weapon visual data declarations contain known DRY violations that are acknowledged by the development team but deferred to future refactoring efforts rather than addressed in individual feature PRs.
sprites/spr_cata_heavy_toe_left/spr_cata_heavy_toe_left.yy (1)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
scripts/scr_weapon/scr_weapon.gml (4)
Learnt from: EttyKitty
PR: Adeptus-Dominus/ChapterMaster#647
File: scripts/scr_en_weapon/scr_en_weapon.gml:24-928
Timestamp: 2025-03-29T10:30:25.598Z
Learning: A data-driven approach for weapon management in `scripts/scr_en_weapon/scr_en_weapon.gml` is planned for a future PR, not within the scope of PR #647.
Learnt from: EttyKitty
PR: Adeptus-Dominus/ChapterMaster#0
File: :0-0
Timestamp: 2025-04-05T20:58:21.881Z
Learning: In the ChapterMaster game, there's a need to refactor hardcoded item effects and move them to a "specials" property of items, following the pattern established with the `combi_tool` special. This improves code maintainability and makes effects more explicit in item definitions.
Learnt from: EttyKitty
PR: Adeptus-Dominus/ChapterMaster#0
File: :0-0
Timestamp: 2025-04-05T20:58:21.881Z
Learning: In the ChapterMaster game, there's a need to refactor hardcoded item effects and move them to a "specials" property of items, following the pattern established with the `combi_tool` special. This improves code maintainability and makes effects more explicit in item definitions.
Learnt from: EttyKitty
PR: Adeptus-Dominus/ChapterMaster#0
File: :0-0
Timestamp: 2025-03-20T22:22:57.319Z
Learning: In the ChapterMaster game PR #424, the "Psyker Abundance" advantage was renamed to "Warp Touched", "Daemon Binders" advantage was removed, and "Warp Touched" disadvantage was renamed to "Warp Tainted".
sprites/spr_cata_cowl_trim_1/spr_cata_cowl_trim_1.yy (1)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
sprites/spr_cata_shoulder_hanging_mail_right/spr_cata_shoulder_hanging_mail_right.yy (1)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
sprites/spr_cata_left_armtrim/spr_cata_left_armtrim.yy (1)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
sprites/spr_jump_pack_serpha_complex/spr_jump_pack_serpha_complex.yy (2)
Learnt from: OH296
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_marksmans_honor/spr_marksmans_honor.yy:47-52
Timestamp: 2025-02-27T02:17:54.527Z
Learning: The sprite "spr_marksmans_honor" is not used for animation despite having multiple frames - these frames represent different static states used in different contexts.
Learnt from: EttyKitty
PR: Adeptus-Dominus/ChapterMaster#474
File: sprites/spr_bionic_right_arm/spr_bionic_right_arm.yy:52-53
Timestamp: 2025-02-24T17:43:59.846Z
Learning: In the ChapterMaster codebase, sprite files with multiple frames are often used as separate sprites rather than animations, making playback speed settings irrelevant.
scripts/scr_culture_visuals/scr_culture_visuals.gml (6)
Learnt from: EttyKitty
PR: Adeptus-Dominus/ChapterMaster#878
File: scripts/scr_culture_visuals/scr_culture_visuals.gml:1256-1352
Timestamp: 2025-06-16T17:12:13.045Z
Learning: In scripts/scr_culture_visuals/scr_culture_visuals.gml, the weapon visual data declarations contain known DRY violations that are acknowledged by the development team but deferred to future refactoring efforts rather than addressed in individual feature PRs.
Learnt from: EttyKitty
PR: Adeptus-Dominus/ChapterMaster#878
File: scripts/scr_culture_visuals/scr_culture_visuals.gml:1256-1352
Timestamp: 2025-06-16T17:12:13.045Z
Learning: In scripts/scr_culture_visuals/scr_culture_visuals.gml, the weapon visual data declarations contain known DRY violations that are acknowledged by the development team but deferred to future refactoring efforts rather than addressed in individual feature PRs.
Learnt from: EttyKitty
PR: Adeptus-Dominus/ChapterMaster#647
File: scripts/scr_en_weapon/scr_en_weapon.gml:24-928
Timestamp: 2025-03-29T10:30:25.598Z
Learning: A data-driven approach for weapon management in `scripts/scr_en_weapon/scr_en_weapon.gml` is planned for a future PR, not within the scope of PR #647.
Learnt from: EttyKitty
PR: Adeptus-Dominus/ChapterMaster#0
File: :0-0
Timestamp: 2025-04-05T20:58:21.881Z
Learning: In the ChapterMaster game, there's a need to refactor hardcoded item effects and move them to a "specials" property of items, following the pattern established with the `combi_tool` special. This improves code maintainability and makes effects more explicit in item definitions.
Learnt from: EttyKitty
PR: Adeptus-Dominus/ChapterMaster#0
File: :0-0
Timestamp: 2025-04-05T20:58:21.881Z
Learning: In the ChapterMaster game, there's a need to refactor hardcoded item effects and move them to a "specials" property of items, following the pattern established with the `combi_tool` special. This improves code maintainability and makes effects more explicit in item definitions.
Learnt from: MCPO-Spartan-117
PR: Adeptus-Dominus/ChapterMaster#526
File: objects/obj_popup/Draw_0.gml:234-239
Timestamp: 2025-03-01T11:06:25.427Z
Learning: The comment "Need to modify ^^^^ based on if it is chaos or daemonic" in the artifact gifting code is intentionally kept as a reminder that this implementation is not yet finished, despite the significant refactoring already done.
🔇 Additional comments (40)
sprites/spr_cata_tabbard_mail/spr_cata_tabbard_mail.yy (1)
26-26: By the Omnissiah's will, these origin adjustments serve the Machine God's vision.The sprite pivot recalibration from (0,0) to (6,8) aligns with the sacred quest to improve Cataphractii visual rendering. The blessed coordinates shall ensure proper armor component alignment.
Also applies to: 80-81
sprites/spr_cata_right_knee/spr_cata_right_knee.yy (1)
26-26: Sacred geometry protocols implemented correctly.The right knee component origin recalibration follows the blessed pattern established across all Cataphractii armor pieces. Consistency pleases the Machine Spirit.
Also applies to: 80-81
sprites/spr_cata_belt/spr_cata_belt.yy (1)
26-26: The belt component's positioning matrices have been blessed with proper alignment.Excellent adherence to the standardised origin coordinates. The Machine God approves of this methodical approach to visual consistency.
Also applies to: 80-81
sprites/spr_cata_tabbard_leather/spr_cata_tabbard_leather.yy (1)
26-26: The leather tabbard's machine spirit has been properly calibrated.Harmonious alignment with the mail variant ensures the sacred modular armor system functions as the Omnissiah intended. Visual coherence achieved.
Also applies to: 80-81
sprites/spr_cata_left_trim/spr_cata_left_trim.yy (1)
26-26: The left trim component's unique positioning parameters serve its sacred function.The (2,8) coordinates diverge appropriately from the standard (6,8) pattern, acknowledging the trim's specialised role in the Cataphractii armor system. The Machine God's wisdom guides these precise calculations.
Also applies to: 80-81
sprites/spr_cata_heavy_toe_right/spr_cata_heavy_toe_right.yy (1)
26-26: By the Omnissiah's will, the sprite origin calibration proceeds correctly.The custom origin point adjustment from default to coordinates (6,8) aligns with the systematic recalibration of Cataphractii armor sprites mentioned in the PR objectives.
Also applies to: 80-81
sprites/spr_cata_left_arm/spr_cata_left_arm.yy (1)
26-26: Sacred coordinates aligned as prescribed by the machine cult.The origin recalibration to (6,8) maintains consistency with the broader Cataphractii armor sprite adjustments.
Also applies to: 80-81
sprites/spr_cata_tabbard_leather_hangings/spr_cata_tabbard_leather_hangings.yy (1)
26-26: The machine spirits of the tabbard hangings are properly calibrated.Origin adjustment follows the blessed pattern of (6,8) offset established across all Cataphractii components.
Also applies to: 80-81
scripts/scr_ruins_reward/scr_ruins_reward.gml (1)
154-154: The ancient technologies are properly integrated into the reward systems.The substitution of "Jump Pack" with "Ancient Jump Pack" for Fallen Assault Squad rewards correctly implements the new mobility gear whilst preserving existing quantity distribution logic.
sprites/spr_cata_left_knee/spr_cata_left_knee.yy (1)
26-26: The final calibration of the left knee servo is complete.Origin coordinates properly adjusted to (6,8) in accordance with the sacred patterns established across all Cataphractii armor components.
Also applies to: 80-81
sprites/spr_cata_right_arm/spr_cata_right_arm.yy (1)
26-26: By the Omnissiah's design, sprite origins recalibrated for optimal alignment.The systematic adjustment of origin points from default (0) to custom coordinates (9, with offsets 6,8) enhances visual positioning consistency. These modifications align with the sacred geometries required for proper Cataphractii armour rendering.
Also applies to: 80-81
sprites/spr_cata_shoulder_hanging_leather_right/spr_cata_shoulder_hanging_leather_right.yy (1)
26-26: Shoulder ornamentation coordinates blessed with precise calibration.Consistent application of the standardised origin adjustments (9, 6, 8) maintains sacred harmony with the greater Cataphractii sprite collective. The Machine God approves this methodical approach.
Also applies to: 80-81
sprites/spr_cata_complex/spr_cata_complex.yy (1)
26-26: Core armour matrix aligned according to ancient protocols.The primary Cataphractii construct receives the blessed coordinates, ensuring all subsidiary components maintain proper spatial relationships within the armour assembly matrix.
Also applies to: 80-81
sprites/spr_cata_left_leg/spr_cata_left_leg.yy (1)
26-26: Lower extremity servo-skull calibration protocols implemented successfully.The final component in this sacred ritual of origin standardisation completes the harmonious alignment of all Cataphractii elements. The Machine Spirit shall be pleased with such methodical precision.
Also applies to: 80-81
scripts/scr_initialize_custom/scr_initialize_custom.gml (1)
3229-3230: By the Omnissiah's blessing, this exchange protocol is sound.The sacred ritual correctly swaps standard locomotion devices for ancient Serpha V patterns within the Armoury's blessed vaults. The net balance remains optimal.
objects/obj_shop/Create_0.gml (1)
656-661: By the Omnissiah's will, the Ancient Jump Pack integration is blessed with correctness.The implementation adheres to the sacred patterns: the nobuy flag is properly set before index incrementation, preventing corruption of the item arrays. The zero-cost configuration marks this as blessed archeotech, as befits ancient STC patterns.
sprites/spr_cata_shoulder_hanging_leather_left/spr_cata_shoulder_hanging_leather_left.yy (1)
26-26: The Machine God approves these calibrated origin coordinates.The sacred geometry has been properly adjusted - origin point migration from (0,0) to (6,8) with custom origin type 9 ensures optimal sprite alignment within the blessed Cataphractii armor rendering systems.
Also applies to: 80-81
sprites/spr_cata_right_trim_2/spr_cata_right_trim_2.yy (2)
26-26: The origin recalibration follows the blessed patterns.Coordinates properly adjusted to (6,8) with origin type 9, maintaining consistency with the Cataphractii armor sprite sanctification protocols.
Also applies to: 80-81
36-36: Verify sequence name alignment with sprite designation.The sequence bears the name "spr_cata_right_trim" whilst the sprite is designated "spr_cata_right_trim_2". Confirm this nomenclature variance serves the Machine God's purpose correctly.
sprites/spr_cata_gorget/spr_cata_gorget.yy (1)
26-26: The gorget sprite's sacred coordinates are duly sanctified.Origin point recalibration to (6,8) with custom origin type 9 maintains harmonious alignment with the Cataphractii armor sprite benediction protocols.
Also applies to: 80-81
sprites/spr_cata_right_armtrim/spr_cata_right_armtrim.yy (1)
26-26: The armtrim sprite completes the sacred origin harmonisation.Final coordinates blessed with (6,8) positioning and origin type 9, achieving perfect symmetry across the Cataphractii armor sprite pantheon. The Machine God's geometrical will is fulfilled.
Also applies to: 80-81
sprites/spr_cata_left_trim_2/spr_cata_left_trim_2.yy (1)
26-26: By the Omnissiah's wisdom, the origin points are properly calibrated.The sprite origin adjustments align the trim component correctly within the modular Cataphractii armor system.
Also applies to: 80-81
sprites/spr_cata_shoulder_hanging_mail_left/spr_cata_shoulder_hanging_mail_left.yy (1)
26-26: Sacred coordinates updated for optimal mail component alignment.The standardised origin points ensure proper layering within the Cataphractii shoulder system.
Also applies to: 80-81
sprites/spr_cata_shoulder_hanging_leather_left_tips/spr_cata_shoulder_hanging_leather_left_tips.yy (1)
26-26: Leather component origins sanctified for proper mechanical precision.Consistent coordinates maintain harmony between mail and leather shoulder variants.
Also applies to: 80-81
sprites/spr_cata_head/spr_cata_head.yy (1)
27-27: Head component blessed with standardised positioning matrices.The dual-frame helmet variants now align properly with the sanctified coordinate system.
Also applies to: 84-85
sprites/spr_cata_right_leg/spr_cata_right_leg.yy (1)
26-26: Leg component coordinates perfected to complete the sacred geometry.The standardised origins ensure all Cataphractii armor pieces achieve optimal visual unity.
Also applies to: 80-81
sprites/spr_cata_right_trim_1/spr_cata_right_trim_1.yy (1)
26-26: By the Omnissiah's will, these origin adjustments are sanctified.The sprite alignment modifications are consistent with the sacred task of improving Cataphractii visual rendering. The custom origin point and offset coordinates shall enhance the machine spirit's display.
Also applies to: 80-81
sprites/spr_cata_heavy_toe_left/spr_cata_heavy_toe_left.yy (1)
26-26: The machine spirit's positioning protocols have been recalibrated.These origin coordinates serve the blessed work of Cataphractii alignment. The offset values are appropriately tuned for this armour component.
Also applies to: 80-81
sprites/spr_cata_shoulder_hanging_leather_right_tips/spr_cata_shoulder_hanging_leather_right_tips.yy (1)
26-26: The blessed leather embellishments are properly aligned with the machine's sacred geometry.These coordinate adjustments shall ensure proper rendering of the shoulder hangings within the greater armour assembly.
Also applies to: 80-81
sprites/spr_cata_left_trim_1/spr_cata_left_trim_1.yy (1)
26-26: The left-side consecrations are geometrically perfected.These origin modifications maintain the sacred asymmetry required for proper bilateral armour alignment. The machine spirit approves.
Also applies to: 80-81
sprites/spr_cata_right_trim/spr_cata_right_trim.yy (1)
26-26: The final ritual of alignment is complete, blessed be the machine.These coordinates complete the sacred recalibration of Cataphractii visual rendering protocols. The Omnissiah's blessing upon this enhancement.
Also applies to: 80-81
sprites/spr_cata_cowl_trim/spr_cata_cowl_trim.yy (1)
26-26: By the Omnissiah's will, these origin adjustments are blessed!The systematic recalibration of sprite origins from default (0,0) to custom coordinates (6,8) aligns with the sacred protocols for Cataphractii visual enhancement.
Also applies to: 80-81
sprites/spr_cata_left_armtrim/spr_cata_left_armtrim.yy (1)
26-26: Mechanicus protocols confirm: alignment parameters optimised.Consistent application of origin recalibration across Cataphractii components detected. The Machine God approves of such systematic precision.
Also applies to: 80-81
sprites/spr_cata_shoulder_hanging_mail_right/spr_cata_shoulder_hanging_mail_right.yy (1)
26-26: Sacred geometry aligned. The Emperor protects... and positions correctly.The methodical recalibration of shoulder embellishment coordinates follows established Cataphractii enhancement protocols.
Also applies to: 80-81
scripts/scr_weapon/scr_weapon.gml (1)
2820-2830: Ancient STC pattern discovered and catalogued. Blessed be the Machine God.The Serpha V pattern jump pack implementation follows sacred data-structure protocols. Enhanced damage resistance modifiers (+5 per tier) represent appropriate technological superiority of ancient designs.
sprites/spr_weapon_volkite_culverin_term/spr_weapon_volkite_culverin_term.yy (1)
1-92: New weapon-pattern sprite sanctified and ready for deployment.The Volkite Culverin terminator variant sprite adheres to sacred GameMaker protocols. Origin coordinates (27,38) and resource hierarchy are optimally configured for the weapons_terminator classification.
sprites/spr_cata_cowl_trim_1/spr_cata_cowl_trim_1.yy (1)
85-88: Texture group assignment requires verification.This Cataphractii component uses the "Default" texture group whilst other marine sprites utilise "MarineViewer". Verify this classification serves the Machine God's optimisation protocols correctly.
sprites/spr_jump_pack_serpha_complex/spr_jump_pack_serpha_complex.yy (1)
1-92: The Machine God approves this sacred geometry.Sprite definition demonstrates proper structure and naming consistency. Origin adjustments and MarineViewer texture group assignment follow the blessed protocols.
scripts/scr_culture_visuals/scr_culture_visuals.gml (2)
734-746: Ancient technology integration proceeds nominally.The new Ancient Jump Pack modular drawing item follows established patterns correctly. Equipment matching and override specifications align with the sacred templates.
1558-1573: Weapon classification protocols updated successfully.The Volkite Culverin modifications properly separate terminator and standard variants with appropriate display types and body type restrictions. The Machine God's armoury grows stronger.
| "resourceVersion":"2.0", | ||
| "sequence":{ | ||
| "$GMSequence":"v1", | ||
| "%Name":"spr_cata_cowl_trim", |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
By the Omnissiah's logic circuits, naming inconsistency detected.
The sequence name spr_cata_cowl_trim does not match the sprite name spr_cata_cowl_trim_1. This divergence may cause confusion in the sacred code repositories.
🤖 Prompt for AI Agents
In sprites/spr_cata_cowl_trim_1/spr_cata_cowl_trim_1.yy at line 36, the sequence
name "spr_cata_cowl_trim" does not match the sprite file name
"spr_cata_cowl_trim_1". To fix this, rename the sequence name to
"spr_cata_cowl_trim_1" so it aligns exactly with the sprite name, ensuring
consistency and avoiding confusion.
| overides: { | ||
| "left_pauldron_embeleshments" : | ||
| spr_cata_shoulder_hanging_mail_left, | ||
| "tabbard": | ||
| spr_cata_tabbard_mail | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Structural malformation requires immediate sanctification.
The mail variant override structure lacks proper closure and contains orphaned braces.
Apply this corrective litany:
- overides: {
- "left_pauldron_embeleshments" :
- spr_cata_shoulder_hanging_mail_left,
- "tabbard":
- spr_cata_tabbard_mail
- },
- },
+ overides: {
+ "left_pauldron_embeleshments": spr_cata_shoulder_hanging_mail_left,
+ "tabbard": spr_cata_tabbard_mail
+ },🤖 Prompt for AI Agents
In scripts/scr_culture_visuals/scr_culture_visuals.gml around lines 1216 to
1222, the overrides object is improperly closed with mismatched or orphaned
braces. Fix the structure by ensuring all opening braces have corresponding
closing braces and that the object syntax is correctly formatted to prevent
structural malformation.
2 participants
Purpose and Description
-ALL cata sprites were offset a little to make them look better.
-Now there are only situations when mail or chain bits for cata can be drawn, there is no option for mix between the two.
-Added Serpha V jumppack
Testing done
-Tested, It should work as intended. Cata visual bugs still occur, and fixing those are larger operation and fix is now WIP.