fix: Mouse deadspot kills popups#955
Merged
OH296 merged 2 commits intoAdeptus-Dominus:mainfrom Aug 2, 2025
Merged
Conversation
Contributor
📝 WalkthroughSummary by CodeRabbit
WalkthroughBy the Omnissiah’s will, this update purges hardcoded numeric literals for popup types and sanctifies the code with the symbolic constant Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Suggested labels
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (6)
🧰 Additional context used📓 Path-based instructions (2)**/*.gml⚙️ CodeRabbit Configuration File
Files:
**/*.*⚙️ CodeRabbit Configuration File
Files:
🧠 Learnings (15)📓 Common learnings📚 Learning: in the chaptermaster game pr #424, the combat log was expanded to display up to 24 messages instead ...Applied to files:
📚 Learning: in the chaptermaster codebase, the correct function to set up gift popups for artifacts is `setup_gi...Applied to files:
📚 Learning: in obj_ingame_menu/step_0.gml, the line "if (effect=14){instance_create(0,0,obj_fade);fading=0.1;}" ...Applied to files:
📚 Learning: in obj_new_button/step_0.gml, when using scr_click_left() for detecting clicks on menu buttons, it s...Applied to files:
📚 Learning: gamemaker studio's function `action_if_variable(image_index, -500, 0)` is auto-generated code from g...Applied to files:
📚 Learning: gamemaker studio's function `action_if_variable(image_index, -500, 0)` was part of an old enemy move...Applied to files:
📚 Learning: marines' ages should be incremented at the year transition in obj_turn_end/alarm_1.gml rather than c...Applied to files:
📚 Learning: in gml, single-line condition checks require the `then` keyword, e.g. `if (condition) then action;`...Applied to files:
📚 Learning: in gamemaker studio 2 (as of the 2023.4 update), `struct_exists(struct, name)` is a valid function t...Applied to files:
📚 Learning: in gamemaker language (gml), both `=` and `==` can be used for equality comparisons and the code wil...Applied to files:
📚 Learning: when refactoring mouse input in chaptermaster, prefer using the `point_and_click([x1, y1, x2, y2])` ...Applied to files:
📚 Learning: in obj_pnunit/alarm_5.gml, the function get_armour_data("maintenance") will always return a numeric ...Applied to files:
📚 Learning: in the chaptermaster game, there's a need to refactor hardcoded item effects and move them to a "spe...Applied to files:
📚 Learning: the variable 'woopwoopwoop' in ancient ruins exploration code is a poorly named boolean flag that co...Applied to files:
🔇 Additional comments (11)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose and Description
Testing done
Related things and/or additional context