Fix initialization of boots slice in ParseBootstraps#8257
Open
fcchbjm wants to merge 3 commits intoAdguardTeam:masterfrom
Open
Fix initialization of boots slice in ParseBootstraps#8257fcchbjm wants to merge 3 commits intoAdguardTeam:masterfrom
fcchbjm wants to merge 3 commits intoAdguardTeam:masterfrom
Conversation
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
| opts *upstream.Options, | ||
| ) (boots []*upstream.UpstreamResolver, err error) { | ||
| boots = make([]*upstream.UpstreamResolver, 0, len(boots)) | ||
| boots = make([]*upstream.UpstreamResolver, 0, len(addrs)) |
There was a problem hiding this comment.
Good catch! The original code was using len(boots) as the capacity, which would always be 0 since the slice is being initialized. This would cause unnecessary reallocations during the append operations. Using len(addrs) is correct since that's the expected final size of the slice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small Performance Optimization
Reduce the time complexity from O(n²) to O(1)