Skip to content

Added try catch and extra cases to safe_serialize#421

Merged
areibman merged 1 commit intomainfrom
eng-634-autogen-safe_serialize-failing
Sep 21, 2024
Merged

Added try catch and extra cases to safe_serialize#421
areibman merged 1 commit intomainfrom
eng-634-autogen-safe_serialize-failing

Conversation

@areibman
Copy link
Copy Markdown
Contributor

📥 Pull Request

📘 Description
Safe serialize really wasn't that safe. Added a try catch and a few more cases

@areibman areibman requested a review from bboynton97 September 21, 2024 00:37
@areibman areibman merged commit 122ad1d into main Sep 21, 2024
@areibman areibman deleted the eng-634-autogen-safe_serialize-failing branch September 21, 2024 00:39
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 18 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
agentops/helpers.py 10.00% 17 Missing and 1 partial ⚠️
Flag Coverage Δ
unittests 44.34% <10.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
agentops/helpers.py 62.24% <10.00%> (-3.69%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants