Conversation
…e files instead of just reporting what would change. After the formatting is done, you should see the changes in git status and be able to commit them.
Contributor
Author
|
Ready for merge @areibman @the-praxs
|
Contributor
Author
|
for the sake of clarity and linear history this PR should not be squashed but git-merged with fast forward, so that the commit showing up on history (git blame) will be run ruff on pre-existing issues
|
Member
|
Think we need to add pre-commit hooks in the repo and add relevant dependencies in the |
Contributor
Author
tru, don' |
areibman
approved these changes
Nov 16, 2024
Contributor
areibman
left a comment
There was a problem hiding this comment.
I <3 clean code. Good stuff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #509
DISCLAIMER
Ruff's formatter is actually compatible with Black's style, so we get the best of both worlds.
We can't have both or they will fight over each-other. Matter of fact, state-of-the-art repositories only go with ruff.
Usage
Install once
Run manually (will run automatically on commit)
Todo
pyproject.tomlto conform with current rules and define new standards; we can decide to ignore rules that won't pass checks for now, and fix those issues on the run or Q5