メッセージをリソースファイルに移動する#4199
Merged
tsuna-can-se merged 8 commits intomainfrom Dec 23, 2025
Hidden character warning
The head ref may contain hidden characters: "feature/\u30e1\u30c3\u30bb\u30fc\u30b8\u3092\u30ea\u30bd\u30fc\u30b9\u30d5\u30a1\u30a4\u30eb\u306b\u79fb\u52d5\u3059\u308b"
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
このPRは、DresscaCMS.AnnouncementとDresscaCMS.Authenticationモジュールにおいて、ハードコーディングされていたメッセージ文字列をリソースファイルに移動するリファクタリングを実施しています。これにより、メッセージの一元管理と将来的なローカライゼーションのサポートが可能になります。
主な変更点:
- DresscaCMS.Authenticationに新しいMessages.resxリソースファイルとその自動生成コードを追加
- DresscaCMS.AnnouncementのMessages.resxとLogMessages.resxに新しいメッセージエントリを追加
- 各モジュールのコードでハードコーディングされた文字列をリソースファイルの参照に置き換え
Reviewed changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| samples/DresscaCMS/src/DresscaCMS.Authentication/Resources/Messages.resx | 接続文字列エラーメッセージのための新しいリソースファイル |
| samples/DresscaCMS/src/DresscaCMS.Authentication/Resources/Messages.Designer.cs | Messages.resxの自動生成された型付きアクセサークラス |
| samples/DresscaCMS/src/DresscaCMS.Authentication/DresscaCMS.Authentication.csproj | リソースファイルのビルド設定を追加 |
| samples/DresscaCMS/src/DresscaCMS.Authentication/AuthenticationServiceCollectionExtensions.cs | ハードコーディングされた接続文字列エラーメッセージをリソース参照に置き換え |
| samples/DresscaCMS/src/DresscaCMS.Announcement/Resources/Messages.resx | パラメータ検証とお知らせメッセージ検索のエラーメッセージを追加 |
| samples/DresscaCMS/src/DresscaCMS.Announcement/Resources/Messages.Designer.cs | 新しいメッセージエントリの型付きプロパティを追加 |
| samples/DresscaCMS/src/DresscaCMS.Announcement/Resources/LogMessages.resx | CRUD操作のログメッセージを追加 |
| samples/DresscaCMS/src/DresscaCMS.Announcement/Resources/LogMessages.Designer.cs | 新しいログメッセージエントリの型付きプロパティを追加 |
| samples/DresscaCMS/src/DresscaCMS.Announcement/ApplicationCore/ApplicationServices/AnnouncementsApplicationService.cs | ハードコーディングされたログメッセージとエラーメッセージをリソース参照に置き換え |
Files not reviewed (3)
- samples/DresscaCMS/src/DresscaCMS.Announcement/Resources/LogMessages.Designer.cs: Language not supported
- samples/DresscaCMS/src/DresscaCMS.Announcement/Resources/Messages.Designer.cs: Language not supported
- samples/DresscaCMS/src/DresscaCMS.Authentication/Resources/Messages.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ssages.Designer.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/ApplicationServices/AnnouncementsApplicationService.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/ApplicationServices/AnnouncementsApplicationService.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
tsuna-can-se
requested changes
Dec 23, 2025
Test Result 📝Test was a success. Coverage 📐Summary
DresscaCMS.Announcement - 4.3%
DresscaCMS.Web - 3.5%
|
tsuna-can-se
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
この Pull request で実施したこと
DresscaCMS.Announcement と DresscaCMS.Authentication のべた書きされていたメッセージをリソースファイルへ移動しました。
この Pull request では実施していないこと
なし
Issues や Discussions 、関連する Web サイトなどへのリンク
#4112