Skip to content

メッセージをリソースファイルに移動する#4199

Merged
tsuna-can-se merged 8 commits intomainfrom
feature/メッセージをリソースファイルに移動する
Dec 23, 2025

Hidden character warning

The head ref may contain hidden characters: "feature/\u30e1\u30c3\u30bb\u30fc\u30b8\u3092\u30ea\u30bd\u30fc\u30b9\u30d5\u30a1\u30a4\u30eb\u306b\u79fb\u52d5\u3059\u308b"
Merged

メッセージをリソースファイルに移動する#4199
tsuna-can-se merged 8 commits intomainfrom
feature/メッセージをリソースファイルに移動する

Conversation

@kharada7
Copy link
Copy Markdown
Contributor

この Pull request で実施したこと

DresscaCMS.Announcement と DresscaCMS.Authentication のべた書きされていたメッセージをリソースファイルへ移動しました。

この Pull request では実施していないこと

なし

Issues や Discussions 、関連する Web サイトなどへのリンク

#4112

Copilot AI review requested due to automatic review settings December 22, 2025 06:42
@kharada7 kharada7 linked an issue Dec 22, 2025 that may be closed by this pull request
@kharada7 kharada7 self-assigned this Dec 22, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

このPRは、DresscaCMS.AnnouncementとDresscaCMS.Authenticationモジュールにおいて、ハードコーディングされていたメッセージ文字列をリソースファイルに移動するリファクタリングを実施しています。これにより、メッセージの一元管理と将来的なローカライゼーションのサポートが可能になります。

主な変更点:

  • DresscaCMS.Authenticationに新しいMessages.resxリソースファイルとその自動生成コードを追加
  • DresscaCMS.AnnouncementのMessages.resxとLogMessages.resxに新しいメッセージエントリを追加
  • 各モジュールのコードでハードコーディングされた文字列をリソースファイルの参照に置き換え

Reviewed changes

Copilot reviewed 6 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
samples/DresscaCMS/src/DresscaCMS.Authentication/Resources/Messages.resx 接続文字列エラーメッセージのための新しいリソースファイル
samples/DresscaCMS/src/DresscaCMS.Authentication/Resources/Messages.Designer.cs Messages.resxの自動生成された型付きアクセサークラス
samples/DresscaCMS/src/DresscaCMS.Authentication/DresscaCMS.Authentication.csproj リソースファイルのビルド設定を追加
samples/DresscaCMS/src/DresscaCMS.Authentication/AuthenticationServiceCollectionExtensions.cs ハードコーディングされた接続文字列エラーメッセージをリソース参照に置き換え
samples/DresscaCMS/src/DresscaCMS.Announcement/Resources/Messages.resx パラメータ検証とお知らせメッセージ検索のエラーメッセージを追加
samples/DresscaCMS/src/DresscaCMS.Announcement/Resources/Messages.Designer.cs 新しいメッセージエントリの型付きプロパティを追加
samples/DresscaCMS/src/DresscaCMS.Announcement/Resources/LogMessages.resx CRUD操作のログメッセージを追加
samples/DresscaCMS/src/DresscaCMS.Announcement/Resources/LogMessages.Designer.cs 新しいログメッセージエントリの型付きプロパティを追加
samples/DresscaCMS/src/DresscaCMS.Announcement/ApplicationCore/ApplicationServices/AnnouncementsApplicationService.cs ハードコーディングされたログメッセージとエラーメッセージをリソース参照に置き換え
Files not reviewed (3)
  • samples/DresscaCMS/src/DresscaCMS.Announcement/Resources/LogMessages.Designer.cs: Language not supported
  • samples/DresscaCMS/src/DresscaCMS.Announcement/Resources/Messages.Designer.cs: Language not supported
  • samples/DresscaCMS/src/DresscaCMS.Authentication/Resources/Messages.Designer.cs: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread samples/DresscaCMS/src/DresscaCMS.Announcement/Resources/LogMessages.Designer.cs Outdated
Comment thread samples/DresscaCMS/src/DresscaCMS.Announcement/Resources/LogMessages.Designer.cs Outdated
kharada7 and others added 5 commits December 22, 2025 15:49
…ssages.Designer.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/ApplicationServices/AnnouncementsApplicationService.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/ApplicationServices/AnnouncementsApplicationService.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@tsuna-can-se tsuna-can-se self-requested a review December 23, 2025 07:46
@tsuna-can-se tsuna-can-se changed the title Feature/メッセージをリソースファイルに移動する メッセージをリソースファイルに移動する Dec 23, 2025
@tsuna-can-se tsuna-can-se added the target: Dressca-CMS サンプルアプリケーションDressca-CMSに関係がある label Dec 23, 2025
@tsuna-can-se tsuna-can-se added this to the v2.0.0 milestone Dec 23, 2025
Comment thread samples/DresscaCMS/src/DresscaCMS.Announcement/Resources/Messages.resx Outdated
Comment thread samples/DresscaCMS/src/DresscaCMS.Announcement/Resources/Messages.resx Outdated
@github-actions
Copy link
Copy Markdown

Test Result 📝

Test was a success.
Completed in 1976ms with 45 passed, 0 failed and 0 skipped.

Coverage 📐

Summary
Generated on: 12/23/2025 - 07:52:45
Parser: MultiReport (3x Cobertura)
Assemblies: 2
Classes: 47
Files: 45
Line coverage: 4.1% (148 of 3599)
Covered lines: 148
Uncovered lines: 3451
Coverable lines: 3599
Total lines: 6457
Branch coverage: 6.2% (28 of 448)
Covered branches: 28
Total branches: 448
Method coverage: Feature is only available for sponsors
Tag: 115_20454866116
DresscaCMS.Announcement - 4.3%
Name Line Branch
DresscaCMS.Announcement 4.3% 12%
DresscaCMS.Announcement.AnnouncementServiceCollectionExtensions 0% 0%
DresscaCMS.Announcement.ApplicationCore.ApplicationServices.AnnouncementsAp
plicationService
20% 28.1%
DresscaCMS.Announcement.ApplicationCore.GetAnnouncementWithHistoriesResult 0%
DresscaCMS.Announcement.ApplicationCore.GetPagedAnnouncementsResult 87.5%
DresscaCMS.Announcement.ApplicationCore.LanguagePriorityProvider 100% 100%
DresscaCMS.Announcement.ApplicationCore.LanguagePriorityProvider.LanguageOr
der
100%
DresscaCMS.Announcement.Infrastructures.AnnouncementDbContext 0% 0%
DresscaCMS.Announcement.Infrastructures.Configurations.AnnouncementConfigur
ation
0% 0%
DresscaCMS.Announcement.Infrastructures.Configurations.AnnouncementContentC
onfiguration
0%
DresscaCMS.Announcement.Infrastructures.Configurations.AnnouncementContentH
istoryConfiguration
0%
DresscaCMS.Announcement.Infrastructures.Configurations.AnnouncementHistoryC
onfiguration
0% 0%
DresscaCMS.Announcement.Infrastructures.EfAnnouncementsRepository 0% 0%
DresscaCMS.Announcement.Infrastructures.Entities.Announcement 100%
DresscaCMS.Announcement.Infrastructures.Entities.AnnouncementContent 62.5% 0%
DresscaCMS.Announcement.Infrastructures.Entities.AnnouncementContentHistory 0% 0%
DresscaCMS.Announcement.Infrastructures.Entities.AnnouncementHistory 0% 0%
DresscaCMS.Announcement.Infrastructures.Migrations.AnnouncementDbContextMod
elSnapshot
0% 0%
DresscaCMS.Announcement.Infrastructures.Migrations.InitialCreate 0% 0%
DresscaCMS.Web - 3.5%
Name Line Branch
DresscaCMS.Web 3.5% 2.8%
AspNetCoreGeneratedDocument.Pages_ServerError 0%
DresscaCMS.Web.Components.Account.IdentityRedirectManager 0% 0%
DresscaCMS.Web.Components.Account.IdentityRevalidatingAuthenticationStatePr
ovider
0% 0%
DresscaCMS.Web.Components.Account.Shared.RedirectToLogin 0%
DresscaCMS.Web.Components.App 0% 0%
DresscaCMS.Web.Components.Layout.MainLayout 0% 0%
DresscaCMS.Web.Components.Layout.NavMenu 0%
DresscaCMS.Web.Components.Pages.AnnouncementCreate 0% 0%
DresscaCMS.Web.Components.Pages.AnnouncementDeleteComplete 0% 0%
DresscaCMS.Web.Components.Pages.AnnouncementDeleteConfirm 0% 0%
DresscaCMS.Web.Components.Pages.AnnouncementEdit 0% 0%
DresscaCMS.Web.Components.Pages.AnnouncementsManagement 0% 0%
DresscaCMS.Web.Components.Pages.Error 100% 100%
DresscaCMS.Web.Components.Pages.Login 0% 0%
DresscaCMS.Web.Components.Pages.Login.InputModel 0%
DresscaCMS.Web.Extensions.AuthenticationStateProviderExtensions 0% 0%
DresscaCMS.Web.State.InMemoryStateStore 100% 100%
DresscaCMS.Web.State.StateResult 80%
DresscaCMS.Web.ViewModels.AnnouncementContentCreateViewModel 0%
DresscaCMS.Web.ViewModels.AnnouncementContentEditViewModel 0%
DresscaCMS.Web.ViewModels.AnnouncementCreateViewModel 0% 0%
DresscaCMS.Web.ViewModels.AnnouncementEditViewModel 0% 0%
DresscaCMS.Web.ViewModels.DeletedAnnouncementState 0%
DresscaCMS.Web.ViewModels.Language 0% 0%
DresscaCMS.Web.ViewModels.LanguagePriorities 0% 0%
Microsoft.Extensions.DependencyInjection.StateStoreExtensions 0%
Microsoft.Extensions.Validation.Generated 0% 0%
Program 0% 0%
System.Runtime.CompilerServices 0%

@tsuna-can-se tsuna-can-se merged commit 0a98f94 into main Dec 23, 2025
8 checks passed
@tsuna-can-se tsuna-can-se deleted the feature/メッセージをリソースファイルに移動する branch December 23, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

target: Dressca-CMS サンプルアプリケーションDressca-CMSに関係がある

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dressca-CMS メッセージをリソースファイルに移動する

3 participants