DresscaのCookieOptions設定をProgram.csに集約する#4669
Merged
tsuna-can-se merged 25 commits intomainfrom Mar 18, 2026
Hidden character warning
The head ref may contain hidden characters: "feature/Dressca\u306eCookieOptions\u8a2d\u5b9a\u3092Program.cs\u306b\u96c6\u7d04\u3059\u308b"
Merged
Conversation
This was
linked to
issues
Mar 3, 2026
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
Dressca の CookieOptions 設定をアプリ全体の CookiePolicy（SameSite / HttpOnly / Secure）として Program.cs に集約し、Cookie ごとに個別設定が必要な項目（Expires / Domain）のみを構成ファイル側で扱えるようにする変更です。重複していた Consumer 側の Configuration クラスを削除し、共通の Dressca.Web.Configuration に寄せています。
Changes:
WebServerOptions.CookieSettingsを「単一設定」から「Cookie 名ごとの設定リスト」に変更し、CreateCookieOptionsで Expires/Domain を適用- Consumer/Admin の
Program.csでCookiePolicyOptionsを構成し、UseCookiePolicyを有効化 - Consumer 側の重複 Configuration クラスを削除し、参照を
Dressca.Web.Configurationに統一
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| samples/Dressca/dressca-backend/src/Dressca.Web/Configuration/WebServerOptions.cs | Cookie 設定をリスト化し、CookiePolicy を反映した CookieOptions 生成を追加 |
| samples/Dressca/dressca-backend/src/Dressca.Web/Configuration/CookieSetting.cs | Cookie 名単位で ExpiredDays / Domain を保持する設定モデルを追加 |
| samples/Dressca/dressca-backend/src/Dressca.Web.Consumer/Program.cs | CookiePolicyOptions を DI 登録し、UseCookiePolicy() を有効化 |
| samples/Dressca/dressca-backend/src/Dressca.Web.Admin/Program.cs | CookiePolicyOptions を追加しつつ、CookiePolicy ミドルウェア設定を分岐追加 |
| samples/Dressca/dressca-backend/src/Dressca.Web.Consumer/Baskets/BuyerIdFilterAttribute.cs | Cookie 作成時に WebServerOptions + CookiePolicyOptions を使うよう変更 |
| samples/Dressca/dressca-backend/tests/Dressca.UnitTests.Web.Consumer/Baskets/BuyerIdFilterAttributeTest.cs | 新コンストラクタ/新 CookieSettings 形式に合わせてテスト更新 |
| samples/Dressca/dressca-backend/src/Dressca.Web.Consumer/appsettings.json | CookieSettings から SameSite/HttpOnly/Secure を削除（※形式不整合あり） |
| samples/Dressca/dressca-backend/src/Dressca.Web.Consumer/appsettings.Development.json | CookieSettings を配列形式へ変更し CookieName を追加 |
| samples/Dressca/dressca-backend/src/Dressca.Web.Consumer/Configuration/*.cs | 重複していた options/validator/settings を削除 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tsuna-can-se
reviewed
Mar 4, 2026
…ストを追加、BuyerIdFilterAttributeのXMLコメントのパラメーター順序を入れ替え
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
…ps://github.com/AlesInfiny/maris into feature/DresscaのCookieOptions設定をProgram.csに集約する
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 16 out of 17 changed files in this pull request and generated 9 comments.
Files not reviewed (1)
- samples/Dressca/dressca-backend/src/Dressca.Web/Resources/Messages.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Test Result 📝Test was a success. Coverage 📐Summary
Dressca.ApplicationCore - 93.5%
Dressca.EfInfrastructure - 14.2%
Dressca.Store.Assets.StaticFiles - 17.2%
Dressca.SystemCommon - 42.3%
Dressca.Web - 32.1%
Dressca.Web.Admin - 29.9%
Dressca.Web.Admin.Dto - 0%
|
Test Result 📝Test was a success. Coverage 📐Summary
Dressca.ApplicationCore - 96%
Dressca.EfInfrastructure - 16.5%
Dressca.Store.Assets.StaticFiles - 17.2%
Dressca.SystemCommon - 42.3%
Dressca.Web - 39.9%
Dressca.Web.Consumer - 53.1%
Dressca.Web.Consumer.Dto - 57.4%
|
tsuna-can-se
approved these changes
Mar 18, 2026
tsuna-can-se
deleted the
feature/DresscaのCookieOptions設定をProgram.csに集約する
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
この Pull request で実施したこと
この Pull request では実施していないこと
なし
Issues や Discussions 、関連する Web サイトなどへのリンク
#4627
#4615