Skip to content

Conversation

@njacazio
Copy link
Collaborator

@njacazio njacazio force-pushed the nj-hftreewriter branch 8 times, most recently from 9b85be2 to 469ca85 Compare November 27, 2020 08:29
@ginnocen ginnocen changed the title Add solid table to be written to file PWGHF: Add solid table to be written to file Dec 21, 2020
Copy link
Collaborator

@ginnocen ginnocen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @njacazio, should we try to merge this? @vkucera @nzardosh do you see any problem with it? We would have to synchronize the commit with the Run3AnalysisValidation corresponding PR.

@ginnocen
Copy link
Collaborator

@njacazio do you have also an equivalent PR for the Lc->pKpi?

@njacazio
Copy link
Collaborator Author

njacazio commented Jan 4, 2021

@ginnocen now the PR has also Lc ! Do you think it is worth to have it merged in O2?

@njacazio njacazio marked this pull request as ready for review January 14, 2021 09:27
@njacazio
Copy link
Collaborator Author

@ginnocen if it's ok with you I would merge this

ginnocen
ginnocen previously approved these changes Jan 16, 2021
@ginnocen ginnocen self-requested a review January 17, 2021 09:12
@ginnocen
Copy link
Collaborator

@DelloStritto please have a look too

@ginnocen
Copy link
Collaborator

Hi @njacazio I am here referring to the fact that we are filling the candidates only once with the mass of the D0, while in principle we know that both mass hypothesis should be considered, D0 and D0bar. We need to think about how to do this in the cleanest way..

@njacazio
Copy link
Collaborator Author

That's fine I will add the D0bar as well

@ginnocen
Copy link
Collaborator

lets have a look at it with the others after the WP414

@ginnocen ginnocen marked this pull request as draft January 21, 2021 12:14
- Add full table to be written to file
- Add task dedicated to 2 prong tree writing
- Add task dedicated to 3 prong tree writing
- Use naming of tasks as in HFSecondaryVertex
@ginnocen ginnocen marked this pull request as ready for review January 21, 2021 20:04
candidate.index2_as<aod::BigTracksPID>().tpcNSigmaKa(),
candidate.index2_as<aod::BigTracksPID>().tofNSigmaPi(),
candidate.index2_as<aod::BigTracksPID>().tofNSigmaKa(),
InvMassLcpKpi(candidate),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, @njacazio @nzardosh @vkucera @DelloStritto are we here only filling the pKpi?

@ginnocen ginnocen merged commit 9b2a233 into AliceO2Group:dev Jan 22, 2021
ginnocen added a commit to ginnocen/AliceO2 that referenced this pull request Jan 23, 2021
jgrosseo pushed a commit that referenced this pull request Jan 23, 2021
@njacazio njacazio deleted the nj-hftreewriter branch February 11, 2021 17:53
EmilGorm pushed a commit to EmilGorm/AliceO2 that referenced this pull request Nov 22, 2021
- Add full table to be written to file
- Add task dedicated to 2 prong tree writing
- Add task dedicated to 3 prong tree writing
- Use naming of tasks as in HFSecondaryVertex
EmilGorm pushed a commit to EmilGorm/AliceO2 that referenced this pull request Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants