PWGHF: Update of the Lc->pKpi selector and task #5013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DelloStritto
commented
Dec 5, 2020
DelloStritto
commented
- Add antiparticles in the Lc selector
- Add the Lc -> pi K p case in the Lc selector
- Commenting out the PID selection in the Lc selector (more tests are needed)
- Move to the histogram registry in the Lc task
- Add the MC matching in the Lc task
DelloStritto
requested review from
ginnocen,
iarsene and
jgrosseo
as code owners
aalkin
reviewed
Dec 6, 2020
Member
There was a problem hiding this comment.
Using int8_t here would use 4 times less memory.
Collaborator
|
Please use draft PR when you don't want to merge |
DelloStritto
force-pushed
the
dev
branch
6 times, most recently
from
e4e901b to
48404f2
Compare
Contributor
|
I think from my side on the selectors this PR is good to go, we already discussed and all the modifications were implemented (I just did not check the MC part) |
Collaborator
|
hi @DelloStritto @nzardosh, thanks to both. If you think is ready for final review and merge, please remove the "DO NOT MERGE". |
DelloStritto
changed the title
ginnocen
reviewed
Dec 20, 2020
Collaborator
vkucera
requested changes
Dec 21, 2020
Analysis/DataModel/include/AnalysisDataModel/HFCandidateSelectionTables.h
Show resolved
Hide resolved
Collaborator
|
Failure unrelated. Merging. |
EmilGorm
pushed a commit
to EmilGorm/AliceO2
that referenced
this pull request
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.