First version of pedestal calibration workflow raw data -> ccdb #5036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiechula
force-pushed
the
RawReaderCRU
branch
2 times, most recently
from
312d890 to
d933a27
Compare
o move calibratoin workflow from calibration to workflow o Change to task for easier handling o Add more processing options o Add sending of calibration data to be able to store them in CCDB
o move common raw data processing function for calibrations to separate file o clean up includes
wiechula
force-pushed
the
RawReaderCRU
branch
from
d933a27 to
19fec6e
Compare
Collaborator
Author
|
@shahor02 , @davidrohr , could you have a look if this can be merged? I fail to understand the problem in the failed tests. The only thing I see is something in CMake which doesn't seem to be related to my commits. |
Collaborator
|
Hi @wiechula |
Collaborator
Author
|
Hi @shahor02 , thanks! The commits are only partly related, so I would prefer not to squash if possible. |
shahor02
approved these changes
Dec 14, 2020
Collaborator
shahor02
left a comment
shahor02
left a comment
There was a problem hiding this comment.
failures unrelated, merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes