TOF DCS Processor #5047

chiarazampolli · 2020-12-10T15:04:44Z

This is the first implementation of the TOF DCS Processor.
Still to-do:

read DPIDs needed by TOF from CCDB
fill CCDB object
process the FEACSTATUS

chiarazampolli · 2020-12-10T15:11:18Z

Hello @aphecetche ,

While implementing the part for TOF, I made a couple of changes to the Generator.

L30 (old), 32 (new) of Detectors/DCS/src/DataPointGenerator.cxx : this is a fix. Without it, the time was random, as "seconds" was uninitialized;
L35 (old), 37 (new) of Detectors/DCS/src/DataPointGenerator.cxx : this is to be able to pass a TDatime, which I need to change the timestamp of the generated DPs (otherwise it was always the same), see Detectors/DCS/testWorkflow/DCSRandomDataGeneratorSpec.h
From L71 (old) 72 (new) of Detectors/DCS/testWorkflow/DCSRandomDataGeneratorSpec.h : I use the TFID to change the timestamp of the generated points. In principle, each point will come with a different timestamp, so also this is a simplification. But what matters is that different maps from DCS have different timestamps for the same DPs
in Detectors/DCS/testWorkflow/DCSRandomDataGeneratorSpec.h , I added TOF (few DPs, just for testing)

Please check that it is fine with you.

Chiara

chiarazampolli · 2020-12-10T15:12:56Z

Detectors/DCS/src/DataPointGenerator.cxx

@aphecetche : this is the fix.

chiarazampolli · 2020-12-10T15:13:15Z

Detectors/DCS/src/DataPointGenerator.cxx

@aphecetche : this is to accept also the TDatime format

chiarazampolli · 2020-12-10T15:13:46Z

Detectors/DCS/testWorkflow/DCSRandomDataGeneratorSpec.h

@aphecetche : this is to be able to change the timestamp at every map that we send, using the TF id.

chiarazampolli · 2020-12-10T15:14:25Z

Detectors/DCS/testWorkflow/DCSRandomDataGeneratorSpec.h

@shahor02 , @aphecetche : DCS will send only 1 map at a time, either FBI or delta.

chiarazampolli · 2020-12-11T11:37:01Z

Detectors/DCS/testWorkflow/DCSRandomDataGeneratorSpec.h

@aphecetche , this is to make the generation of the DPs in the delta map such that there are no duplicated DPs - the delta map will contain one value only per DP.

chiarazampolli · 2020-12-11T13:57:53Z

Detectors/DCS/testWorkflow/DCSRandomDataGeneratorSpec.h

@aphecetche : this is to change the subset of DPs that are generated at every TF

shahor02 · 2020-12-11T23:34:23Z

Detectors/DCS/testWorkflow/DCSRandomDataGeneratorSpec.h

this seems to be never used.

chiarazampolli · 2020-12-14T12:42:37Z

Dear @noferini , @shahor02 , @aphecetche ,

I am done with the changes I wanted to make to this PR, so I removed the WIP from the title. As soon as the basic checks will pass, can you review it?

Thanks!

Chiara

chiarazampolli · 2020-12-15T07:48:44Z

Hello @shahor02 , @noferini , @aphecetche ,

The only error I could find in https://ali-ci.cern.ch/alice-build-logs/AliceO2Group/AliceO2/5047/e6413573c142517866c4bca5f7f2174b881f7beb/build_O2_o2/fullLog.txt is:

Error in TSystem::ExpandFileName: input: $ROOT_DYN_PATH/libRIO, output: $ROOT_DYN_PATH/libRIO
Error in TSystem::ExpandFileName: input: $ROOT_DYN_PATH/libCling, output: $ROOT_DYN_PATH/libCling

But it is not related to this PR. Any idea? Is there something else?

Chiara

sawenzel · 2020-12-15T07:54:44Z

@chiarazampolli : This error is annoying but not critical. It just means that the variable ROOT_DYN_PATH (announced to ROOT somewhere) is not set in the compilation environment.
As far as I can tell, the build is 100% ok. Maybe @TimoWilken can comment why one of them is flagged as failed.

chiarazampolli · 2020-12-15T08:17:54Z

Ciao @sawenzel ,
Thanks! I did not spot any other error, is it normal that this one triggers the failure of o2 build?
Chiara

shahor02 · 2020-12-15T08:35:39Z

Hi Chiara, It reports a failure due to the "Manually-specified variables were not used by the project:" warning in cmake, see the entry page of https://ali-ci.cern.ch/alice-build-logs/AliceO2Group/AliceO2/5047/e6413573c142517866c4bca5f7f2174b881f7beb/build_O2_o2/pretty.html. Just ignore it. Cheers Ruben Get Outlook for Android<https://aka.ms/ghei36>

…

________________________________ From: Chiara Zampolli <notifications@github.com> Sent: Tuesday, December 15, 2020 8:48:59 AM To: AliceO2Group/AliceO2 <AliceO2@noreply.github.com> Cc: Ruben Shahoyan <shahor02@gmail.com>; Mention <mention@noreply.github.com> Subject: Re: [AliceO2Group/AliceO2] TOF DCS Processor (#5047) Hello @shahor02<https://github.com/shahor02> , @noferini<https://github.com/noferini> , @aphecetche<https://github.com/aphecetche> , The only error I could find in https://ali-ci.cern.ch/alice-build-logs/AliceO2Group/AliceO2/5047/e6413573c142517866c4bca5f7f2174b881f7beb/build_O2_o2/fullLog.txt is: Error in TSystem::ExpandFileName: input: $ROOT_DYN_PATH/libRIO, output: $ROOT_DYN_PATH/libRIO Error in TSystem::ExpandFileName: input: $ROOT_DYN_PATH/libCling, output: $ROOT_DYN_PATH/libCling But it is not related to this PR. Any idea? Is there something else? Chiara — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#5047 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABYKIDK47NXYJSFPG4IKMYDSU4IGXANCNFSM4UVETWWQ>.

chiarazampolli · 2020-12-15T09:48:46Z

Thanks Ruben!

Chiara

shahor02

Hi @chiarazampolli

Please see a few comments below (only 1 is a real bug).

Detectors/DCS/testWorkflow/DCSRandomDataGeneratorSpec.h

Detectors/DCS/testWorkflow/dcs-sim-workflow.cxx

Detectors/TOF/calibration/include/TOFCalibration/TOFDCSProcessor.h

Detectors/TOF/calibration/macros/CMakeLists.txt

Detectors/TOF/calibration/src/TOFDCSProcessor.cxx

shahor02 · 2020-12-15T22:12:23Z

Detectors/TOF/calibration/testWorkflow/TOFDCSDataProcessorSpec.h

so, the double DPs will be saved only once in the very end of the workflow lifetime, which might be large. Is this what you want?

For now, I think it is ok, but we can change it to have it ever n TFs. I will do this modification in another PR, if you agree.

Ok, will take care in January :-)

Adding processing of LV info (FEAC). Processing also HV Configuring DPs for TOF either from CCDB or by hand. Macro included to create CCDB entry Preparing CCDB update Writing to CCDB Some updates and improvements more in the README, for LHCphase, ChannelOffset, TimeSlewing formatting of README formatting of README clang-format clang again update README add macro makeCCDBEntryForDCS.C to tests including algorithm shuffle instead of random_shuffle fix for macro test (hopefully) Fix for test Now it should work! Making CI happy from PR review turning test into executable typo fixed clang again clang

chiarazampolli · 2020-12-15T23:23:33Z

A side remark about something weird: after running clang-format, I still get an error, in a file that I think clang-format itself changed at the previous iteration.

TimoWilken · 2020-12-16T08:22:04Z

Hi @chiarazampolli! I'm trying to track down some other weirdness in the clang-format checker. Do you happen to have a log with that error somewhere? It might be useful...

chiarazampolli · 2020-12-16T08:42:15Z

Ciao @TimoWilken ,

Unfortunately not, the logs were those from the CI, so they are lost now.

Chiara

TimoWilken · 2020-12-16T08:46:28Z

Hi @chiarazampolli, fair enough! Please let me know if you see it happen again.

chiarazampolli · 2020-12-16T09:02:00Z

Ciao @TimoWilken ,

Sure!

Chiara

shahor02 · 2020-12-16T20:27:47Z

@chiarazampolli @noferini shall I merge it or Francesco wants to review it?

chiarazampolli · 2020-12-16T22:02:56Z

Hello,

@noferini is away, I think, until end of the holidays. Maybe we could merge it, and in case make modifications? In this way we can send it around as an example (and the README also can be useful).

Chiara

chiarazampolli requested review from a team and noferini as code owners December 10, 2020 15:04

chiarazampolli commented Dec 10, 2020

View reviewed changes

Detectors/DCS/src/DataPointGenerator.cxx Outdated

Copy link

Collaborator Author

chiarazampolli Dec 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aphecetche : this is the fix.

chiarazampolli commented Dec 10, 2020

View reviewed changes

Detectors/DCS/src/DataPointGenerator.cxx Outdated

Copy link

Collaborator Author

chiarazampolli Dec 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aphecetche : this is to accept also the TDatime format

chiarazampolli commented Dec 10, 2020

View reviewed changes

chiarazampolli commented Dec 11, 2020

View reviewed changes

shahor02 reviewed Dec 11, 2020

View reviewed changes

Detectors/DCS/testWorkflow/DCSRandomDataGeneratorSpec.h Outdated

Copy link

Collaborator

shahor02 Dec 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to be never used.

chiarazampolli force-pushed the DCS branch from 41ecda2 to 649bee1 Compare December 14, 2020 12:41

chiarazampolli changed the title ~~[WIP] TOF DCS Processor~~ TOF DCS Processor Dec 14, 2020

chiarazampolli force-pushed the DCS branch 9 times, most recently from 29a70ff to e641357 Compare December 14, 2020 23:04

shahor02 requested changes Dec 15, 2020

View reviewed changes

chiarazampolli force-pushed the DCS branch 2 times, most recently from c78f6c0 to 2cdb050 Compare December 15, 2020 23:06

chiarazampolli force-pushed the DCS branch 2 times, most recently from f0c2623 to af4d2dc Compare December 15, 2020 23:11

chiarazampolli force-pushed the DCS branch from af4d2dc to 2920fea Compare December 15, 2020 23:22

shahor02 approved these changes Dec 16, 2020

View reviewed changes

shahor02 merged commit 0fe332f into AliceO2Group:dev Dec 16, 2020

chiarazampolli deleted the DCS branch May 16, 2022 07:53

TOF DCS Processor #5047

TOF DCS Processor #5047

Uh oh!

Conversation

chiarazampolli commented Dec 10, 2020

Uh oh!

chiarazampolli commented Dec 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chiarazampolli commented Dec 14, 2020

Uh oh!

chiarazampolli commented Dec 15, 2020

Uh oh!

sawenzel commented Dec 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chiarazampolli commented Dec 15, 2020

Uh oh!

shahor02 commented Dec 15, 2020 via email

Uh oh!

chiarazampolli commented Dec 15, 2020

Uh oh!

shahor02 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chiarazampolli commented Dec 15, 2020

Uh oh!

TimoWilken commented Dec 16, 2020

Uh oh!

chiarazampolli commented Dec 16, 2020

Uh oh!

TimoWilken commented Dec 16, 2020

Uh oh!

chiarazampolli commented Dec 16, 2020

Uh oh!

shahor02 commented Dec 16, 2020

Uh oh!

chiarazampolli commented Dec 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

chiarazampolli commented Dec 10, 2020 •

edited

Loading

sawenzel commented Dec 15, 2020 •

edited

Loading