Skip to content

Conversation

@mario-krueger
Copy link
Member

No description provided.

jgrosseo
jgrosseo previously approved these changes Dec 11, 2020
@ktf
Copy link
Member

ktf commented Dec 11, 2020

Can you remove the WIP when you are done? LGTM.

@mario-krueger
Copy link
Member Author

Hi @njacazio ,
this commit changes the interfaces of the registry for .fill() and .get().
We want to have the histogram names hashed only once at compile time and not every time we use it in the access functions.
This introduces a bit of an inconvenience for your code since now it is no longer possible to do things like:

for (int i = 0; i < Np; i++) {
  histos.fill(HIST(hexpected[i]), mom, exp[i]);
  histos.fill(HIST(hexpected_diff[i]), mom, t.tpcSignal() - exp[i]);
}

as the name used to fill the histogram cannot be depending on a running index any longer (since this variable is not fixed at compile time).
I have provided a workaround for your code. Maybe you can have a look if this is fine with you (it is put in a separate commit so it can be reverted more easily if needed).
These were rather invasive changes and it might be good if you could confirm that your tasks still work as expected after applying these modifications.

@mario-krueger mario-krueger changed the title [WIP] DPL Analysis: use compile-time hashed histogram names in registry DPL Analysis: use compile-time hashed histogram names in registry Dec 11, 2020
@njacazio
Copy link
Collaborator

@mkruegerGitHub thanks for the information! I will try your patch and check !

@ktf ktf merged commit 49406d6 into AliceO2Group:dev Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants