Initial version of EMCAL Correction Task #5074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@raymondEhlers I think you need to rebase the include directory structure has changed |
It doesn't run correctly - it segfaults due to the input data - but it's at least running. We can uncomment the code once things start working
I now get clusters (they may or may not be correct...)
Contributor
Author
|
@jgrosseo Thanks, I overlooked this. It should be fixed now |
raymondEhlers
force-pushed
the
emcalDev
branch
from
f7a6f31 to
9f09c83
Compare
jgrosseo
requested changes
Dec 18, 2020
Collaborator
jgrosseo
left a comment
jgrosseo
left a comment
There was a problem hiding this comment.
Thanks for this work.
Generally it is fine with me. See the two comments.
jgrosseo
approved these changes
Jan 5, 2021
EmilGorm
pushed a commit
to EmilGorm/AliceO2
that referenced
this pull request
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial version of the EMCAL Correction Task. It still needs some further bug fixes and QA, but it is far enough along that it's worth merging and allowing others to work on it