[ITS][ntracker-workflow] Add --configKeyValue for MB LUT #5076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mconcas
force-pushed
the
n-tracker-wf-config
branch
from
8936844 to
af150a6
Compare
mconcas
force-pushed
the
n-tracker-wf-config
branch
from
af150a6 to
5fd81b5
Compare
shahor02
approved these changes
Dec 17, 2020
Collaborator
shahor02
left a comment
shahor02
left a comment
There was a problem hiding this comment.
Looks ok, thanks. CI failure is unrelated, merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shahor02
I pulled out the loading of the matbud.root file from tracking parameters configuration, so this should also work independently from the
--asyncmode. It is toggleable with:--configKeyValues 'ITSCATrackerParam.useMatBudLUT=true'This is a possible implementation, we can discuss on that.
Also ping @mpuccio for review.
For macro-based approach the tracker has explicit handle for file loading.
Cheers