Skip to content

Conversation

@ktf
Copy link
Member

@ktf ktf commented Jan 12, 2021

No description provided.

@ktf ktf requested a review from a team as a code owner January 12, 2021 15:39
@ktf ktf changed the title DPL: do not mask errros when generating workflows DPL: do not mask errors when generating workflows Jan 12, 2021
@ktf ktf force-pushed the workflow-generation branch from 1403fb6 to 554fcfb Compare January 12, 2021 17:01
@ktf
Copy link
Member Author

ktf commented Jan 12, 2021

@davidrohr @mfasDa can you check if this improves your building issues?

@ktf
Copy link
Member Author

ktf commented Jan 13, 2021

@knopers8 @Barthelemy this fails to generate the workflow configuration because the datasampling is not a real standalone workflow. Can we move to use o2_add_executable rather than o2_add_workflow?

@davidrohr
Copy link
Collaborator

@ktf : For reference: rebuilding with this PR, I am still getting the segfaults

[Mi Jan 13 09:52:06 2021] o2-testworkflow[19695]: segfault at 0 ip 0000000000000000 sp 00007ffeb315d5b8 error 14 in o2-testworkflows-aod-dummy-workflow[55a881839000+7000]
[Mi Jan 13 09:52:06 2021] Code: Unable to access opcode bytes at RIP 0xffffffffffffffd6.

due to the zero function pointer, but at least now the build fails properly:

FAILED: stage/bin/o2-analysistutorial-associated-derived
2021-01-13@09:52:07:DEBUG:O2:O2:0: [ERROR] libO2FrameworkAnalysisSupport.so: cannot open shared object file: No such file or directory
2021-01-13@09:52:07:DEBUG:O2:O2:0: [ERROR] /usr/lib64/libuv.so.1: undefined symbol: dpl_plugin_callback

@knopers8
Copy link
Collaborator

@knopers8 @Barthelemy this fails to generate the workflow configuration because the datasampling is not a real standalone workflow. Can we move to use o2_add_executable rather than o2_add_workflow?

OK, sure. I'll post a fix soon.

@davidrohr
Copy link
Collaborator

rebased to dev, since the dependency is apparently required for the build order.

@sawenzel sawenzel merged commit b894bce into AliceO2Group:dev Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants