DPL: do not mask errors when generating workflows#5161
Merged
sawenzel merged 2 commits intoAliceO2Group:devfrom Jan 15, 2021
Merged
DPL: do not mask errors when generating workflows#5161sawenzel merged 2 commits intoAliceO2Group:devfrom
sawenzel merged 2 commits intoAliceO2Group:devfrom
Conversation
1403fb6 to
554fcfb
Compare
Member
Author
|
@davidrohr @mfasDa can you check if this improves your building issues? |
Member
Author
|
@knopers8 @Barthelemy this fails to generate the workflow configuration because the datasampling is not a real standalone workflow. Can we move to use o2_add_executable rather than o2_add_workflow? |
Collaborator
|
@ktf : For reference: rebuilding with this PR, I am still getting the segfaults due to the zero function pointer, but at least now the build fails properly: |
Collaborator
OK, sure. I'll post a fix soon. |
Collaborator
|
rebased to dev, since the dependency is apparently required for the build order. |
sawenzel
approved these changes
Jan 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.