Fixes in entropy compression memory management #5178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahor02
requested review from
a team,
aphecetche,
bovulpes,
davidrohr,
iouribelikov,
kharlov,
mfasDa,
noferini,
peressounko and
wiechula
as code owners
davidrohr
previously approved these changes
Jan 13, 2021
Collaborator
davidrohr
left a comment
davidrohr
left a comment
There was a problem hiding this comment.
Looks reasonable, did you try it on my data that was failing, or do you want me to retry?
Initial allocation decreased for large buffers and increased for small ones
Collaborator
Author
|
@davidrohr yes, I've tried and it works. Actually, the problem in that particular case was not too small buffer but smaller than actually available buffer size indicated to rANS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.