Skip to content

Add split tables per particle species in PID response #5182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jgrosseo merged 1 commit into from
Jan 19, 2021
Merged

Add split tables per particle species in PID response #5182

jgrosseo merged 1 commit into from
Jan 19, 2021

Conversation

@njacazio
Copy link
Collaborator

@njacazio njacazio commented Jan 14, 2021

@jgrosseo jgrosseo marked this pull request as draft January 14, 2021 08:13
@iarsene
Copy link
Collaborator

iarsene commented Jan 14, 2021 •
edited
Loading

Hi @njacazio, @jgrosseo,
The new task implementation which produces tables per hypothesis for all cases, would not have the same footprint as the one that produces a single table with all hypotheses as columns? Downstream tasks indeed would have the opportunity to consume exactly what they need.

@njacazio
Copy link
Collaborator Author

njacazio commented Jan 14, 2021

@iarsene yes, you are perfectly right and this is intended.
The plan would be to have it tailor fitted to the needs of the workflow but this is in the longer terms.
For now we want to test the possibility to have large joins of small tables and the effect on the compilation.

@njacazio njacazio force-pushed the nj-o2PID-dyn-cols branch 3 times, most recently from ca50672 to 949149f Compare January 18, 2021 08:36
@njacazio
Copy link
Collaborator Author

njacazio commented Jan 18, 2021

@jgrosseo this should be ready for review

jgrosseo
jgrosseo previously approved these changes Jan 18, 2021
View reviewed changes
@jgrosseo jgrosseo marked this pull request as ready for review January 18, 2021 10:01
@njacazio
Add split tables per particle species in PID response
74cc0a8 
- Add user tasks for TOF and TPC spectra dedicated to the usage of the new tables via long join chains
- Add tasks for the creation of sub tables per PID
- Add user tasks
- Avoid local mem copy
@jgrosseo jgrosseo merged commit d90bf64 into AliceO2Group:dev Jan 19, 2021
@njacazio njacazio deleted the nj-o2PID-dyn-cols branch January 20, 2021 08:26
EmilGorm pushed a commit to EmilGorm/AliceO2 that referenced this pull request Nov 22, 2021
@njacazio @jgrosseo
Add split tables per particle species in PID response (AliceO2Group#5182
d16de3f 
)

- Add user tasks for TOF and TPC spectra dedicated to the usage of the new tables via long join chains
- Add tasks for the creation of sub tables per PID
- Add user tasks
- Avoid local mem copy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgrosseo jgrosseo jgrosseo approved these changes

@iarsene iarsene Awaiting requested review from iarsene

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@njacazio @iarsene @jgrosseo