Skip to content

Fixed memory leak in DataContainer3D #5197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sawenzel merged 1 commit into from
Jan 20, 2021
Merged

Fixed memory leak in DataContainer3D #5197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Detectors/TPC/spacecharge/include/TPCSpaceCharge/DataContainer3D.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ bool DataContainer3D<DataT, Nx, Ny, Nz>::initFromFile(TFile& inpf, const char* n
return false;
}
mData = dataCont->mData;
delete dataCont;
Copy link
Collaborator

@sawenzel sawenzel Jan 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the same should be done a few lines further down?

Copy link
Contributor Author

@matthias-kleiner matthias-kleiner Jan 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean the loadFromFile() function? There the pointer is just returned and I think shouldnt be deleted? But since this function is actually never used in any of the SpaceCharge classes, it might be better to just remove the function and keep the class more simple.

return true;
}

Expand Down