TPC Workflow: Move cluster / digit reading from tpc tracking spec into a helper #5216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidrohr
force-pushed
the
dev_pull_request2
branch
from
8db31d7 to
159d34c
Compare
Collaborator
Author
|
OK, this was actually simpler than I thought, did some tests with the tpc workflow and the full system test and all seems fine for. Will need further adjustment in QC once this is merged. |
davidrohr
force-pushed
the
dev_pull_request2
branch
from
159d34c to
1b1df77
Compare
davidrohr
force-pushed
the
dev_pull_request2
branch
from
1b1df77 to
ce8efa6
Compare
shahor02
approved these changes
Jan 18, 2021
Collaborator
shahor02
left a comment
shahor02
left a comment
There was a problem hiding this comment.
@davidrohr thanks, works fine!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge yet, this is just the CI test for the first part in the tpc tracking spec. Will also adjust all the other consumers of TPC clusters / digits.
@shahor02 : This should clean up the cluster reading.