Skip to content

Conversation

@preghenella
Copy link
Collaborator

This PR fixes the selective transport feature which was not operative in the parallel simulation

@preghenella preghenella requested a review from sawenzel as a code owner January 19, 2021 10:43
@preghenella preghenella force-pushed the rdev-fix-parallel-inhibit branch from 3b2abf7 to dce9ba5 Compare January 19, 2021 11:33
@preghenella
Copy link
Collaborator Author

@sawenzel
common function is added

@preghenella
Copy link
Collaborator Author

@sawenzel
the second commit of this PR introduces a new bit in the PropEncoding to store the inhibit flag.
The location of the tobedone bit is unchanged.
Notice that I have reduced the hitMask field to 18 bits, given that there are 18 detectors (I might be wrong in case this is not the logic). This frees some room and we have 5 more bits that are currently unused.

This commit is not mandatory for this PR.
But it might come at handy to track what happens in the selective transport functionality.
It will be eventually needed for the "pause-and-continue" developments.

sawenzel
sawenzel previously approved these changes Jan 19, 2021
@preghenella preghenella force-pushed the rdev-fix-parallel-inhibit branch from 926b18f to 8ffd45d Compare January 19, 2021 15:41
@sawenzel
Copy link
Collaborator

Needed urgently for next nightly test. Compilation checked locally.

@sawenzel sawenzel merged commit c0cdf30 into AliceO2Group:dev Jan 19, 2021
@preghenella preghenella deleted the rdev-fix-parallel-inhibit branch January 19, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants