file reader for TPC Tracks and Clusters (+ MC info)

[tklemenz]

This adds a file reader workflow to read either tracks (with or without MC info) or clusters (with or without MC info) from file and provides them in the DPL.

• Read tracks: o2-tpc-file-reader --infile tpctracks.root --input-type tracks
• Read clusters: o2-tpc-file-reader --infile tpc-native-clusters.root --input-type clusters

[davidrohr]

@tklemenz : I think it might be helpful to add the option to distribute both clusters and tracks.
Have you tested it with the new TPC QC task, which has been merged into QC in the meantime?

[tklemenz]

Hi @davidrohr, I agree, this might be useful. I will look into it.

Until now I only tested the file reader with the "old" QC workflows but I will check with your new one and let you know.

[davidrohr]

Thx, I think this is important in particular for the MC labels, since I believe they are not used in the other tasks. The instructions are in this JIRA ticket: https://alice.its.cern.ch/jira/browse/QC-519?filter=-2

[tklemenz]

@davidrohr, I checked with your TrackingQA and it ran without issues. When I do --disable-mc it does not run and complains about a missing output for CLNATIVEMCLBL. So as far as I can judge it works. You can have a look at the output on the qcg test page if you want. It is the histograms from ~15:50 on 22 Jan. (simulated 1000 pp 14TeV events with the pythia8 generator).
All mean, rms, and eff plots are empty. Is this related to the file reader not working, the simulated data or the QA task itself?

When the reading of clusters and tracks at the same time works, I will update the PR. I ran the test above calling the file reader twice.

@shahor02, I will remove the mentioned customization and the dispatching-mode and add the tracks to the description.

[davidrohr]

@tklemenz : Thx, the output on the qcg page looks OK. Those efficiency histograms are empty in the mergeable output. They would only be filled when the postprocessing runs. I guess I should remove them completely when the output is set to mergeable.

[tklemenz]

I am thinking how to make the reader read two files at a time.

My problem is, that the DataProcessorSpec which reads the clusters is created by the PublisherSpec, which has the option infile. The part reading the tracks is the standalone TrackreaderSpec, which has the option tpc-track-file (in the PR this is also called infile but I meanwhile changed it back, because I think otherwise it won't work to read two files). Now if I put both options in the command line when calling the o2-tpc-file-reader exe both parts don't know one of the options.

A dirty workaround is to add the option tpc-track-file to the PublisherSpec and the option infile to the TrackreaderSpec. Then it works as intended but obviously no one wants that "solution". So what I would like to do is to add an option infile-clusters and infile-tracks (or maybe a comma separated list infiles) to the FileReaderWorkflow via the customize function and somehow pass the file path info to the getPublisherSpec and the getTPCTrackReaderSpec functions. For the latter this should be easy to implement but for the former I don't see if/how this would work.

Do you have an idea maybe?
The MatchTPCITSWorkflow I assume is also reading multiple files. Can you guide me a bit how it is done there?

[shahor02]

@tklemenz it should work with --infile for both readers, provided you put each of them in quotes, i.e.

o2-tpc-file-reader --tpc-track-reader '--infile tpctracks.root' --tpc-native-cluster-reader '--infile tpc-native-clusters.root'

[tklemenz]

Yes! Thanks a lot, this works. I will push the changes asap.

[tklemenz]

This does not necessarily need to be there. I could also include the RecoWorkflow header and use the OutputType enum from there instead and adjust the InputMap but I think this is the nicer solution.

[davidrohr]

I think this is ok, it is not so much code... :)
When you are ready, can you remove the WIP such that the CI runs, or is there still something to update?

[shahor02]

@tklemenz could you remove [WIP] to trigger the CI tests?

[tklemenz]

I rebased on the latest dev branch and removed WIP.