Templatize PrimaryVertexer inputs #5364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahor02
requested review from
a team,
AllaMaevskaya,
jotwinow and
mslupeck
as code owners
Collaborator
Author
|
CI failure is unrelated, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @njacazio
you can use this as a starting point to rewrite #5359.
Note that I still provide containers of labels called lblITS and lblTPC, but these are usual spans of MCCompLabels, in
particular case of PVertexertSpec corresponding to ITS and TPC parts of the global track. I may find better solution later,
but at the moment you can provide for both arguments the same span of labels of whatever tracks you are providing as 1st argument.