Skip to content

Fix: ensure exact target X assignment in track propagation #5376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shahor02 merged 1 commit into from
Feb 3, 2021
Merged

Fix: ensure exact target X assignment in track propagation #5376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DataFormats/Reconstruction/src/TrackParametrization.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ GPUd() bool TrackParametrization<value_T>::propagateParamTo(value_t xk, const di

// Calculate the track parameters
t = 1.f / gpu::CAMath::Sqrt(vecLab[3] * vecLab[3] + vecLab[4] * vecLab[4]);
mX = x;
mX = xk;
mP[kY] = y;
mP[kZ] = z;
mP[kSnp] = vecLab[4] * t;
Expand Down
2 changes: 1 addition & 1 deletion DataFormats/Reconstruction/src/TrackParametrizationWithError.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,7 @@ GPUd() bool TrackParametrizationWithError<value_T>::propagateTo(value_t xk, cons

// Calculate the track parameters
t = 1.f / gpu::CAMath::Sqrt(vecLab[3] * vecLab[3] + vecLab[4] * vecLab[4]);
this->setX(x);
this->setX(xk);
this->setY(y);
this->setZ(z);
this->setSnp(vecLab[4] * t);
Expand Down
4 changes: 4 additions & 0 deletions Detectors/Base/src/Propagator.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ GPUd() bool Propagator::PropagateToXBxByBz(o2::track::TrackParCov& track, float
}
dx = xToGo - track.getX();
}
track.setX(xToGo);
return true;
}

Expand Down Expand Up @@ -221,6 +222,7 @@ GPUd() bool Propagator::PropagateToXBxByBz(o2::track::TrackPar& track, float xTo
}
dx = xToGo - track.getX();
}
track.setX(xToGo);
return true;
}

Expand Down Expand Up @@ -279,6 +281,7 @@ GPUd() bool Propagator::propagateToX(o2::track::TrackParCov& track, float xToGo,
}
dx = xToGo - track.getX();
}
track.setX(xToGo);
return true;
}

Expand Down Expand Up @@ -337,6 +340,7 @@ GPUd() bool Propagator::propagateToX(o2::track::TrackPar& track, float xToGo, fl
}
dx = xToGo - track.getX();
}
track.setX(xToGo);
return true;
}

Expand Down