Skip to content

Conversation

@aalkin
Copy link
Member

@aalkin aalkin commented Feb 5, 2021

Use a semicolon as a field separator for config parsing, this allows to send values with whitespaces (e.g. array labels).

@aalkin aalkin requested review from a team, iarsene and jgrosseo as code owners February 5, 2021 14:56
@ktf
Copy link
Member

ktf commented Feb 7, 2021

@rbx here is another issue, this time notice it has nothing to do with DPL:

/mnt/mesos/sandbox/sandbox/o2-fullci/sw/slc8_x86-64/FairMQ/v1.4.29-1/lib/libFairMQ.so.1.4(_ZN5boost12interprocess9ipcdetail14semaphore_waitEP5sem_t+0xb)[0x7f8f6f8a7c7b]
/mnt/mesos/sandbox/sandbox/o2-fullci/sw/slc8_x86-64/FairMQ/v1.4.29-1/lib/libFairMQ.so.1.4(_ZN4fair2mq5shmem7ManagerC2ENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEES8_mPKNS0_11ProgOptionsE+0x83d)[0x7f8f6f8def8d]
/mnt/mesos/sandbox/sandbox/o2-fullci/sw/slc8_x86-64/FairMQ/v1.4.29-1/lib/libFairMQ.so.1.4(_ZN4fair2mq5shmem16TransportFactoryC1ERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEPKNS0_11ProgOptionsE+0x93a)[0x7f8f6f8e1c2a]
/mnt/mesos/sandbox/sandbox/o2-fullci/sw/slc8_x86-64/FairMQ/v1.4.29-1/lib/libFairMQ.so.1.4(_ZN22FairMQTransportFactory22CreateTransportFactoryERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEES7_PKN4fair2mq11ProgOptionsE+0x14c)[0x7f8f6f89f0bc]
/mnt/mesos/sandbox/sandbox/o2-fullci/sw/BUILD/c953ddccfc8835f26a1b69dac6c619b8fad7847e/O2/stage/tests/o2-test-memoryresources-MemoryResources[0x4107b4]

@ktf
Copy link
Member

ktf commented Feb 8, 2021

Wouldn't it be better to escape the spaces, rather than moving the problem to ";"?

@aalkin
Copy link
Member Author

aalkin commented Feb 8, 2021

Wouldn't it be better to escape the spaces, rather than moving the problem to ";"?

We use our own parsing there, with an explicit check for the next separator symbol in the full string, escaping is simply ignored.

@ktf
Copy link
Member

ktf commented Feb 8, 2021

Ok. Now that the ws has landed we should probably switch to a proper serialisation method for the config.

@ktf ktf merged commit 50a1ef5 into AliceO2Group:dev Feb 8, 2021
EmilGorm pushed a commit to EmilGorm/AliceO2 that referenced this pull request Nov 22, 2021
@aalkin aalkin deleted the fix-config-with-whitespace branch May 30, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants